Chromium Code Reviews| Index: chrome/browser/ui/tab_helpers.h |
| diff --git a/chrome/browser/ui/tab_helpers.h b/chrome/browser/ui/tab_helpers.h |
| index 1c678f2b55a08b530b7c09e7db86c4f0b2ee0b15..fdc777b8ab83156ed0ef14ba5bbdfcd334c07c1a 100644 |
| --- a/chrome/browser/ui/tab_helpers.h |
| +++ b/chrome/browser/ui/tab_helpers.h |
| @@ -25,6 +25,8 @@ class PrerenderContents; |
| // (or the equivalent on Android). The TabHelpers class allows specific classes |
| // to attach the set of tab helpers that is used for tab contents. |
| // |
| +// http://www.chromium.org/developers/design-documents/tab-helpers |
|
felt
2015/07/31 22:34:10
nit: https pls?
Avi (use Gerrit)
2015/08/01 21:33:44
Yes, of course.
|
| +// |
| // TODO(avi): This list is rather large, and for most callers it's due to the |
| // fact that they need tab helpers attached early to deal with arbitrary |
| // content loaded into a WebContents that will later be added to the tabstrip. |
| @@ -50,6 +52,10 @@ class TabHelpers { |
| // the full set of tab helpers to deal with it. |
| friend class prerender::PrerenderContents; |
| + // FYI: Do NOT add any functions here. The functions above are the ONLY ones |
| + // that need to call AttachTabHelpers; if you think you do, re-read the design |
| + // document linked above, especially the section "Reusing tab helpers". |
| + |
| // Adopts the specified WebContents as a full-fledged browser tab, attaching |
| // all the associated tab helpers that are needed for the WebContents to |
| // serve in that role. It is safe to call this on a WebContents that was |