Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4251)

Unified Diff: chrome/browser/sync/test/integration/multiple_client_password_manager_setting_migrater_service_sync_test.cc

Issue 1256803002: [Smart Lock, Prefs reconciliation] Prefs migration logic for desktop platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add guard Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/multiple_client_password_manager_setting_migrater_service_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/multiple_client_password_manager_setting_migrater_service_sync_test.cc b/chrome/browser/sync/test/integration/multiple_client_password_manager_setting_migrater_service_sync_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f652fe8363f4e8e9677def273933893faa6a2455
--- /dev/null
+++ b/chrome/browser/sync/test/integration/multiple_client_password_manager_setting_migrater_service_sync_test.cc
@@ -0,0 +1,99 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/prefs/pref_service.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/password_manager/password_manager_setting_migrater_service.h"
+#include "chrome/browser/prefs/pref_service_syncable.h"
+#include "chrome/browser/sync/test/integration/preferences_helper.h"
+#include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
+#include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
+#include "chrome/browser/sync/test/integration/sync_test.h"
+#include "chrome/common/pref_names.h"
+#include "components/password_manager/core/common/password_manager_pref_names.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/notification_source.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+
+using preferences_helper::AwaitBooleanPrefMatches;
+using preferences_helper::BooleanPrefMatches;
+using preferences_helper::ChangeBooleanPref;
+using preferences_helper::GetPrefs;
+
+class MultipleClientPasswordManagerSettingMigraterServiceSyncTest
+ : public SyncTest {
+ public:
+ MultipleClientPasswordManagerSettingMigraterServiceSyncTest()
+ : SyncTest(MULTIPLE_CLIENT) {}
+ ~MultipleClientPasswordManagerSettingMigraterServiceSyncTest() override {}
+
+ bool SetupClients() override {
+ if (!SyncTest::SetupClients())
+ return false;
+ DisableVerifier();
+ return true;
+ }
+
+ void NotifyProfileAdded(int index) {
+ content::NotificationService::current()->Notify(
+ chrome::NOTIFICATION_PROFILE_ADDED,
+ content::Source<Profile>(GetProfile(index)),
+ content::NotificationService::NoDetails());
+ }
+
+ bool TestUsesSelfNotifications() override { return false; }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(
+ MultipleClientPasswordManagerSettingMigraterServiceSyncTest);
+};
+
+IN_PROC_BROWSER_TEST_F(
+ MultipleClientPasswordManagerSettingMigraterServiceSyncTest,
+ TwoClientsWithMigrationOneClientWithoutChangeFromOnToOff) {
+ DisableVerifier();
+ ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
+ NotifyProfileAdded(0);
+ NotifyProfileAdded(1);
+ ASSERT_TRUE(AwaitBooleanPrefMatches(
+ password_manager::prefs::kPasswordManagerSavingEnabled));
+ // Client without migration changes the legacy pref.
+ ChangeBooleanPref(2, password_manager::prefs::kPasswordManagerSavingEnabled);
+ ASSERT_TRUE(AwaitBooleanPrefMatches(
+ password_manager::prefs::kPasswordManagerSavingEnabled));
+ ASSERT_TRUE(AwaitBooleanPrefMatches(
+ password_manager::prefs::kPasswordManagerSavingEnabled));
+ // Check that new and legacy preferences have correct value on client with
+ // migration.
+ for (int i = 0; i < num_clients() - 1; ++i) {
+ EXPECT_FALSE(GetPrefs(i)->GetBoolean(
+ password_manager::prefs::kCredentialsEnableService));
+ EXPECT_FALSE(GetPrefs(i)->GetBoolean(
+ password_manager::prefs::kPasswordManagerSavingEnabled));
+ }
+}
+
+IN_PROC_BROWSER_TEST_F(
+ MultipleClientPasswordManagerSettingMigraterServiceSyncTest,
+ TwoClientsWithMigrationOneClientWithoutChangeFromOffToOn) {
+ DisableVerifier();
+ ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
+ NotifyProfileAdded(0);
+ NotifyProfileAdded(1);
+ ASSERT_TRUE(AwaitBooleanPrefMatches(
+ password_manager::prefs::kPasswordManagerSavingEnabled));
+ ChangeBooleanPref(0, password_manager::prefs::kPasswordManagerSavingEnabled);
+ ASSERT_TRUE(AwaitBooleanPrefMatches(
+ password_manager::prefs::kPasswordManagerSavingEnabled));
+ ChangeBooleanPref(0, password_manager::prefs::kPasswordManagerSavingEnabled);
+ ASSERT_TRUE(AwaitBooleanPrefMatches(
+ password_manager::prefs::kPasswordManagerSavingEnabled));
+ for (int i = 0; i < num_clients() - 1; ++i) {
+ EXPECT_TRUE(GetPrefs(i)->GetBoolean(
+ password_manager::prefs::kCredentialsEnableService));
+ EXPECT_TRUE(GetPrefs(i)->GetBoolean(
+ password_manager::prefs::kPasswordManagerSavingEnabled));
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698