[Smart Lock, Prefs reconciliation] Prefs migration logic for desktop platforms.

chrome/browser/password_manager/password_manager_setting_migrater_service_unittests.cc

Index: chrome/browser/password_manager/password_manager_setting_migrater_service_unittests.cc
diff --git a/chrome/browser/password_manager/password_manager_setting_migrater_service_unittests.cc b/chrome/browser/password_manager/password_manager_setting_migrater_service_unittests.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c66159c7bbbad32695327b47dd27e7c02087127c
--- /dev/null
+++ b/chrome/browser/password_manager/password_manager_setting_migrater_service_unittests.cc
@@ -0,0 +1,264 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/json/json_string_value_serializer.h"
+#include "base/prefs/pref_registry_simple.h"
+#include "base/prefs/pref_service.h"
+#include "base/values.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/chromeos/login/session/user_session_manager.h"
+#include "chrome/browser/password_manager/password_manager_setting_migrater_service.h"
+#include "chrome/browser/prefs/pref_service_syncable.h"
+#include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "chrome/browser/sync/profile_sync_service_mock.h"
+#include "chrome/test/base/testing_pref_service_syncable.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/password_manager/core/common/password_manager_pref_names.h"
+#include "components/pref_registry/pref_registry_syncable.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/notification_source.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "sync/api/fake_sync_change_processor.h"
+#include "sync/api/sync_error_factory.h"
+#include "sync/api/sync_error_factory_mock.h"
+#include "sync/internal_api/public/attachments/attachment_service_proxy_for_test.h"
+#include "sync/protocol/preference_specifics.pb.h"
+#include "sync/protocol/priority_preference_specifics.pb.h"
+#include "sync/protocol/sync.pb.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+enum PrefState {
+  OFF,
+  ON,
+  EMPTY,  // datatype bucket is empty
+  UNSET,  // datatype doesn't arrive from sync
+};
+
+syncer::SyncData CreatePrefSyncData(const std::string& name, bool value) {
+  std::string serialized;
+  JSONStringValueSerializer json(&serialized);
+  base::FundamentalValue bool_value(value);
+  json.Serialize(bool_value);
+  sync_pb::EntitySpecifics specifics;
+  sync_pb::PreferenceSpecifics* pref = nullptr;
+  if (name == password_manager::prefs::kPasswordManagerSavingEnabled)
+    pref = specifics.mutable_preference();
+  else if (name == password_manager::prefs::kCredentialsEnableService)
+    pref = specifics.mutable_priority_preference()->mutable_preference();
+  else
+    NOTREACHED() << "Wrong preference name: " << name;
+  pref->set_name(name);
+  pref->set_value(serialized);
+  return syncer::SyncData::CreateRemoteData(
+      1, specifics, base::Time(), syncer::AttachmentIdList(),
+      syncer::AttachmentServiceProxyForTest::Create());
+}
+
+void SetPrefValueIfNeeded(PrefService* prefs,
+                          const std::string& name,
+                          PrefState value) {
+  if (value != EMPTY || value != UNSET) {
+    prefs->SetBoolean(name, value);
+  }
+}
+
+// Emulates start of the syncing for the specific sync type. If |name| is
+// kPasswordManagerSavingEnabled preference, then it's PREFERENCE data type.
+// If |name| is kCredentialsEnableService  pref, then it's PRIORITY_PREFERENCE
+// data type.
+void StartSyncing(PrefServiceSyncable* prefs,
+                  const std::string& name,
+                  syncer::SyncDataList sync_data_list) {
+  syncer::ModelType type = syncer::UNSPECIFIED;
+  if (name == password_manager::prefs::kPasswordManagerSavingEnabled)
+    type = syncer::PREFERENCES;
+  else if (name == password_manager::prefs::kCredentialsEnableService)
+    type = syncer::PRIORITY_PREFERENCES;
+  ASSERT_NE(syncer::UNSPECIFIED, type) << "Wrong preference name: " << name;
+  syncer::SyncableService* sync = prefs->GetSyncableService(type);
+  sync->MergeDataAndStartSyncing(
+      type, sync_data_list, scoped_ptr<syncer::SyncChangeProcessor>(
+                                new syncer::FakeSyncChangeProcessor),
+      scoped_ptr<syncer::SyncErrorFactory>(new syncer::SyncErrorFactoryMock));
+}
+
+void StartSyncingPrefWithValue(PrefServiceSyncable* prefs,
+                               const std::string& name,
+                               PrefState value) {
+  if (value == UNSET)
+    return;
+  if (value == EMPTY) {
+    StartSyncing(prefs, name, syncer::SyncDataList());
+  } else {
+    syncer::SyncDataList sync_data_list;
+    sync_data_list.push_back(CreatePrefSyncData(name, value));
+    StartSyncing(prefs, name, sync_data_list);
+  }
+}
+}  // namespace
+
+namespace password_manager {
+
+class PasswordManagerSettingMigraterServiceTest : public testing::Test {
+ public:
+  PasswordManagerSettingMigraterServiceTest() {}
+
+  void SetUp() override { ResetProfile(); }
+
+  Profile* profile() { return profile_.get(); }
+
+  void ResetProfile() {
+    profile_ = TestingProfile::Builder().Build();
+    ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
+        profile(), &ProfileSyncServiceMock::BuildMockProfileSyncService);
+    EXPECT_CALL(*profile_sync_service(), CanSyncStart())
+        .WillRepeatedly(testing::Return(true));
+  }
+
+  ProfileSyncServiceMock* profile_sync_service() {
+    return static_cast<ProfileSyncServiceMock*>(
+        ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile()));
+  }
+
+  void NotifyProfileAdded() {
+    content::NotificationService::current()->Notify(
+        chrome::NOTIFICATION_PROFILE_ADDED, content::Source<Profile>(profile()),
+        content::NotificationService::NoDetails());
+  }
+
+  void TestOnLocalChange(const std::string& name, bool value) {
+    NotifyProfileAdded();
+    PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile());
+    prefs->SetBoolean(name, value);
+    EXPECT_EQ(prefs->GetBoolean(prefs::kCredentialsEnableService), value);
+    EXPECT_EQ(prefs->GetBoolean(prefs::kPasswordManagerSavingEnabled), value);
+  }
+
+  void TestWithPrefDataComingFromSync(PrefState new_pref_value,
+                                      PrefState legacy_pref_value,
+                                      bool final_value) {
+    PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile());
+    StartSyncingPrefWithValue(prefs, prefs::kCredentialsEnableService,
+                              new_pref_value);
+    StartSyncingPrefWithValue(prefs, prefs::kPasswordManagerSavingEnabled,
+                              legacy_pref_value);
+    EXPECT_EQ(prefs->GetBoolean(prefs::kCredentialsEnableService), final_value);
+    EXPECT_EQ(prefs->GetBoolean(prefs::kPasswordManagerSavingEnabled),
+              final_value);
+  }
+
+ private:
+  content::TestBrowserThreadBundle thread_bundle_;
+  scoped_ptr<TestingProfile> profile_;
+};
+
+TEST_F(PasswordManagerSettingMigraterServiceTest,
+       ReconcileOnLocalChangeOfPasswordManagerSavingEnabledOn) {
+  TestOnLocalChange(prefs::kPasswordManagerSavingEnabled, true);
+}
+
+TEST_F(PasswordManagerSettingMigraterServiceTest,
+       ReconcileOnLocalChangeOfPasswordManagerSavingEnabledOff) {
+  TestOnLocalChange(prefs::kPasswordManagerSavingEnabled, false);
+}
+
+TEST_F(PasswordManagerSettingMigraterServiceTest,
+       ReconcileOnLocalChangeOfCredentialsEnableServiceOn) {
+  TestOnLocalChange(prefs::kCredentialsEnableService, true);
+}
+
+TEST_F(PasswordManagerSettingMigraterServiceTest,
+       ReconcileOnLocalChangeOfCredentialsEnableServiceOff) {
+  TestOnLocalChange(prefs::kCredentialsEnableService, false);
+}
+
+TEST_F(PasswordManagerSettingMigraterServiceTest,
+       ReconcileOnSyncMergeEmptyDataFinished) {
+  // kPasswordManagerSavingEnabled is set to "off" and kCredentialsEnableService
+  // is created for the first time with default value "on". Data which has came
+  // from sync doesn't contain changes for these preferences, so after sync has
+  // finished merging, both preferences should be "off".
+  PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile());
+  prefs->SetBoolean(prefs::kPasswordManagerSavingEnabled, false);
+  EXPECT_EQ(prefs->GetBoolean(prefs::kCredentialsEnableService), true);
+  NotifyProfileAdded();
+  EXPECT_EQ(prefs->GetBoolean(prefs::kCredentialsEnableService), true);
+  EXPECT_EQ(prefs->GetBoolean(prefs::kPasswordManagerSavingEnabled), false);
+  // Empty data comes from sync.
+  StartSyncing(prefs, prefs::kPasswordManagerSavingEnabled,
+               syncer::SyncDataList());
+  StartSyncing(prefs, prefs::kCredentialsEnableService, syncer::SyncDataList());
+  EXPECT_EQ(prefs->GetBoolean(prefs::kCredentialsEnableService), false);
+  EXPECT_EQ(prefs->GetBoolean(prefs::kPasswordManagerSavingEnabled), false);
+}
+
+TEST_F(PasswordManagerSettingMigraterServiceTest,
+       ReconcileWhenWhenBothPrefsTypesArrivesFromSync) {
+  struct {
+    PrefState new_pref_local_value;
+    PrefState old_pref_local_value;
+    PrefState new_pref_sync_value;
+    PrefState old_pref_sync_value;
+    bool result_value;
+  } testing_table[] = {
+      {EMPTY, EMPTY, EMPTY, EMPTY, true}, {OFF, OFF, EMPTY, EMPTY, false},
+      {OFF, OFF, OFF, UNSET, false},      {OFF, ON, ON, UNSET, true},
+      {OFF, OFF, UNSET, OFF, false},      {OFF, OFF, UNSET, ON, true},
+      {OFF, OFF, OFF, ON, true},          {OFF, OFF, OFF, OFF, false},
+      {OFF, OFF, ON, OFF, true},          {ON, OFF, ON, ON, true},
+      {ON, ON, OFF, EMPTY, false},        {ON, ON, ON, EMPTY, true},
+      {ON, ON, EMPTY, OFF, false},        {ON, ON, EMPTY, ON, true},
+      {ON, ON, OFF, OFF, false},          {ON, ON, OFF, ON, false},
+      {ON, ON, ON, OFF, false},           {ON, ON, ON, ON, true},
+      {EMPTY, EMPTY, ON, EMPTY, true},    {EMPTY, EMPTY, OFF, EMPTY, false},
+      {EMPTY, EMPTY, EMPTY, ON, true},    {EMPTY, EMPTY, EMPTY, OFF, false},
+  };
+
+  for (const auto& test_case : testing_table) {
+    ResetProfile();
+    SCOPED_TRACE(testing::Message("Local data = ")
+                 << test_case.old_pref_local_value << " "
+                 << test_case.new_pref_local_value);
+    SCOPED_TRACE(testing::Message("Sync data = ")
+                 << test_case.old_pref_sync_value << " "
+                 << test_case.new_pref_sync_value);
+    PrefService* prefs = profile()->GetPrefs();
+    SetPrefValueIfNeeded(prefs, prefs::kPasswordManagerSavingEnabled,
+                         test_case.old_pref_local_value);
+    SetPrefValueIfNeeded(prefs, prefs::kCredentialsEnableService,
+                         test_case.new_pref_local_value);
+    NotifyProfileAdded();
+    TestWithPrefDataComingFromSync(test_case.new_pref_sync_value,
+                                   test_case.old_pref_sync_value,
+                                   test_case.result_value);
+  }
+}
+
+TEST_F(PasswordManagerSettingMigraterServiceTest,
+       ReconcileWhenSyncIsNotExpectedPasswordManagerEnabledOff) {
+  PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile());
+  prefs->SetBoolean(prefs::kPasswordManagerSavingEnabled, false);
+  EXPECT_CALL(*profile_sync_service(), CanSyncStart())
+      .WillRepeatedly(testing::Return(false));
+  NotifyProfileAdded();
+  EXPECT_EQ(prefs->GetBoolean(prefs::kCredentialsEnableService), false);
+  EXPECT_EQ(prefs->GetBoolean(prefs::kPasswordManagerSavingEnabled), false);
+}
+
+TEST_F(PasswordManagerSettingMigraterServiceTest,
+       ReconcileWhenSyncIsNotExpectedPasswordManagerEnabledOn) {
+  PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile());
+  prefs->SetBoolean(prefs::kPasswordManagerSavingEnabled, true);
+  EXPECT_EQ(prefs->GetBoolean(prefs::kCredentialsEnableService), true);
+  EXPECT_CALL(*profile_sync_service(), CanSyncStart())
+      .WillRepeatedly(testing::Return(false));
+  NotifyProfileAdded();
+  EXPECT_EQ(prefs->GetBoolean(prefs::kCredentialsEnableService), true);
+  EXPECT_EQ(prefs->GetBoolean(prefs::kPasswordManagerSavingEnabled), true);
+}
+
+}  // namespace password_manager