[Smart Lock, Prefs reconciliation] Prefs migration logic for desktop platforms.

chrome/browser/sync/test/integration/two_client_password_manager_setting_migrater_service_sync_test.cc

Index: chrome/browser/sync/test/integration/two_client_password_manager_setting_migrater_service_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_password_manager_setting_migrater_service_sync_test.cc b/chrome/browser/sync/test/integration/two_client_password_manager_setting_migrater_service_sync_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..638c88d8efdc0a7d73b281a1727a04636a95ac82
--- /dev/null
+++ b/chrome/browser/sync/test/integration/two_client_password_manager_setting_migrater_service_sync_test.cc
@@ -0,0 +1,93 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/prefs/pref_service.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/password_manager/password_manager_setting_migrater_service.h"
+#include "chrome/browser/prefs/pref_service_syncable.h"
+#include "chrome/browser/sync/test/integration/preferences_helper.h"
+#include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
+#include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
+#include "chrome/browser/sync/test/integration/sync_test.h"
+#include "chrome/common/pref_names.h"
+#include "components/password_manager/core/common/password_manager_pref_names.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/notification_source.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+
+using preferences_helper::AwaitBooleanPrefMatches;
+using preferences_helper::BooleanPrefMatches;
+using preferences_helper::ChangeBooleanPref;
+using preferences_helper::GetPrefs;
+
+class TwoClientsPasswordManagerSettingMigraterServiceSyncTest
+    : public SyncTest {
+ public:
+  TwoClientsPasswordManagerSettingMigraterServiceSyncTest()
+      : SyncTest(TWO_CLIENT) {}
+
+  bool SetupClients() override {
+    if (!SyncTest::SetupClients())
+      return false;
+    for (int i = 0; i < num_clients(); ++i)
+      content::NotificationService::current()->Notify(
+          chrome::NOTIFICATION_PROFILE_ADDED,
+          content::Source<Profile>(GetProfile(i)),
+          content::NotificationService::NoDetails());
+    DisableVerifier();
+    return true;
+  }
+
+  ~TwoClientsPasswordManagerSettingMigraterServiceSyncTest() override {}
+
+  Profile* profile() { return GetProfile(0); }
+  bool TestUsesSelfNotifications() override { return false; }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(
+      TwoClientsPasswordManagerSettingMigraterServiceSyncTest);
+};
+
+IN_PROC_BROWSER_TEST_F(TwoClientsPasswordManagerSettingMigraterServiceSyncTest,
+                       ChangeLegacyPrefTest) {
+  ASSERT_TRUE(SetupSync());
+  ASSERT_TRUE(AwaitBooleanPrefMatches(
+      password_manager::prefs::kPasswordManagerSavingEnabled));
+  ASSERT_TRUE(AwaitBooleanPrefMatches(
+      password_manager::prefs::kCredentialsEnableService));
+
+  ChangeBooleanPref(1, password_manager::prefs::kPasswordManagerSavingEnabled);
+  ASSERT_TRUE(AwaitBooleanPrefMatches(
+      password_manager::prefs::kPasswordManagerSavingEnabled));
+  ASSERT_TRUE(AwaitBooleanPrefMatches(
+      password_manager::prefs::kCredentialsEnableService));
+  for (int i = 0; i < num_clients(); ++i) {
+    ASSERT_FALSE(GetPrefs(i)->GetBoolean(

[vabr (Chromium), 2015/08/14 14:11:45]

Should we have a similar test before updating the prefs to document that they
are both true in the beginning?
Why are they true in the beginning, actually?

[melandory, 2015/08/17 16:28:56]

Default value.

+        password_manager::prefs::kCredentialsEnableService));
+    ASSERT_FALSE(GetPrefs(i)->GetBoolean(
+        password_manager::prefs::kPasswordManagerSavingEnabled));
+  }
+}
+
+IN_PROC_BROWSER_TEST_F(TwoClientsPasswordManagerSettingMigraterServiceSyncTest,
+                       ChangeNewPrefTest) {
+  ASSERT_TRUE(SetupSync());
+  ASSERT_TRUE(AwaitBooleanPrefMatches(
+      password_manager::prefs::kPasswordManagerSavingEnabled));
+  ASSERT_TRUE(AwaitBooleanPrefMatches(
+      password_manager::prefs::kCredentialsEnableService));
+
+  ChangeBooleanPref(1, password_manager::prefs::kCredentialsEnableService);
+  ASSERT_TRUE(AwaitBooleanPrefMatches(
+      password_manager::prefs::kPasswordManagerSavingEnabled));
+  ASSERT_TRUE(AwaitBooleanPrefMatches(
+      password_manager::prefs::kCredentialsEnableService));
+  for (int i = 0; i < num_clients(); ++i) {
+    ASSERT_FALSE(GetPrefs(i)->GetBoolean(
+        password_manager::prefs::kCredentialsEnableService));
+    ASSERT_FALSE(GetPrefs(i)->GetBoolean(
+        password_manager::prefs::kPasswordManagerSavingEnabled));
+  }
+}