components/password_manager/core/browser/password_manager_settings_migration_experiment.cc - Issue 1256803002: [Smart Lock, Prefs reconciliation] Prefs migration logic for desktop platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_settings_migration_experiment.cc

Issue 1256803002: [Smart Lock, Prefs reconciliation] Prefs migration logic for desktop platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager.cc ('k') | components/password_manager/core/browser/password_manager_settings_migration_experiment_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_settings_migration_experiment.cc

diff --git a/components/password_manager/core/browser/password_manager_settings_migration_experiment.cc b/components/password_manager/core/browser/password_manager_settings_migration_experiment.cc

index 31f3bff2867a2a3f70ff889e1dd7bc5dcf8a4dec..fa0fdf30a797a6e93e78cd88158d692d78cf58bf 100644

--- a/components/password_manager/core/browser/password_manager_settings_migration_experiment.cc

+++ b/components/password_manager/core/browser/password_manager_settings_migration_experiment.cc

@@ -5,14 +5,16 @@

#include "components/password_manager/core/browser/password_manager_settings_migration_experiment.h"

#include "base/metrics/field_trial.h"

+#include "base/strings/string_util.h"

namespace password_manager {

bool IsSettingsMigrationActive() {

const char kFieldTrialName[] = "PasswordManagerSettingsMigration";

- const char kEnabledGroupName[] = "PasswordManagerSettingsMigration.Enable";

- return base::FieldTrialList::FindFullName(kFieldTrialName) ==

- kEnabledGroupName;

+ const char kEnabledGroupNamePrefix[] = "Enable";

+ return base::StartsWith(base::FieldTrialList::FindFullName(kFieldTrialName),

+ kEnabledGroupNamePrefix,

+ base::CompareCase::INSENSITIVE_ASCII);

}

bool IsSettingsBehaviorChangeActive() {