Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2203)

Unified Diff: chrome/browser/sync/test/integration/two_client_password_manager_setting_migrator_service_sync_test.cc

Issue 1256803002: [Smart Lock, Prefs reconciliation] Prefs migration logic for desktop platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/two_client_password_manager_setting_migrator_service_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_password_manager_setting_migrator_service_sync_test.cc b/chrome/browser/sync/test/integration/two_client_password_manager_setting_migrator_service_sync_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d374b011d1da67a6480ed69ed5beaa9b53fc01d7
--- /dev/null
+++ b/chrome/browser/sync/test/integration/two_client_password_manager_setting_migrator_service_sync_test.cc
@@ -0,0 +1,120 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/prefs/pref_service.h"
+#include "chrome/browser/sync/test/integration/password_manager_setting_migrator_helper.h"
+#include "chrome/browser/sync/test/integration/preferences_helper.h"
+#include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
+#include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
+#include "chrome/browser/sync/test/integration/sync_test.h"
+#include "chrome/common/pref_names.h"
+#include "components/password_manager/core/common/password_manager_pref_names.h"
+#include "components/syncable_prefs/pref_service_syncable.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+
+using password_manager_setting_migrater_helper::ExpectPrefValuesOnClient;
+using preferences_helper::AwaitBooleanPrefMatches;
+using preferences_helper::GetPrefs;
+using password_manager::prefs::kPasswordManagerSavingEnabled;
+using password_manager::prefs::kCredentialsEnableService;
+
+class TwoClientsPasswordManagerSettingMigratorServiceSyncTest
+ : public SyncTest {
+ public:
+ TwoClientsPasswordManagerSettingMigratorServiceSyncTest()
+ : SyncTest(TWO_CLIENT) {}
+
+ ~TwoClientsPasswordManagerSettingMigratorServiceSyncTest() override {}
+
+ bool SetupClients() override {
+ if (!SyncTest::SetupClients())
+ return false;
+ DisableVerifier();
+ return true;
+ }
+
+ // Changes the |pref_name| preference value on the client with |index| and
+ // checks that the value is the same on both clients after the change.
+ void TestPrefChangeOnClient(int index, const char* pref_name) {
+ ASSERT_TRUE(AwaitBooleanPrefMatches(kPasswordManagerSavingEnabled));
+ ASSERT_TRUE(AwaitBooleanPrefMatches(kCredentialsEnableService));
+
+ preferences_helper::ChangeBooleanPref(index, pref_name);
+ // Check that changed pref has the same value on both clients
+ ASSERT_TRUE(AwaitBooleanPrefMatches(kPasswordManagerSavingEnabled));
+ ASSERT_TRUE(AwaitBooleanPrefMatches(kCredentialsEnableService));
+ }
+
+ void EnsureMigrationStartsForClient(int index) {
+ password_manager_setting_migrater_helper::SetupFieldTrial();
+ password_manager_setting_migrater_helper::SendProfileAddNotification(
+ GetProfile(index));
+ }
+
+ void ExpectValueOnBothClientsForBothPreference(bool value) {
+ for (int i = 0; i < num_clients(); ++i) {
+ ExpectPrefValuesOnClient(i, value, value);
+ }
+ }
+
+ Profile* profile() { return GetProfile(0); }
+ bool TestUsesSelfNotifications() override { return false; }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(
+ TwoClientsPasswordManagerSettingMigratorServiceSyncTest);
+};
+
+IN_PROC_BROWSER_TEST_F(TwoClientsPasswordManagerSettingMigratorServiceSyncTest,
+ ChangeLegacyPrefTestBothClientsWithMigration) {
+ ASSERT_TRUE(SetupSync());
+ EnsureMigrationStartsForClient(0);
+ EnsureMigrationStartsForClient(1);
+ TestPrefChangeOnClient(1, kPasswordManagerSavingEnabled);
+}
+
+IN_PROC_BROWSER_TEST_F(TwoClientsPasswordManagerSettingMigratorServiceSyncTest,
+ ChangeNewPrefTestBothClientsWithMigration) {
+ ASSERT_TRUE(SetupClients());
+ EnsureMigrationStartsForClient(0);
+ EnsureMigrationStartsForClient(1);
+ ASSERT_TRUE(SetupSync());
+ TestPrefChangeOnClient(1, kCredentialsEnableService);
+}
+
+IN_PROC_BROWSER_TEST_F(
+ TwoClientsPasswordManagerSettingMigratorServiceSyncTest,
+ ChangeLegacyPrefOnMigratedClientOneClientsWithMigration) {
+ ASSERT_TRUE(SetupSync());
+ EnsureMigrationStartsForClient(0);
+ TestPrefChangeOnClient(0, kPasswordManagerSavingEnabled);
+ ExpectValueOnBothClientsForBothPreference(false);
+}
+
+IN_PROC_BROWSER_TEST_F(
+ TwoClientsPasswordManagerSettingMigratorServiceSyncTest,
+ ChangeLegacyPrefOnNonMigratedClientOneClientsWithMigration) {
+ ASSERT_TRUE(SetupSync());
+ EnsureMigrationStartsForClient(0);
+ TestPrefChangeOnClient(1, kPasswordManagerSavingEnabled);
+ ExpectValueOnBothClientsForBothPreference(false);
+}
+
+IN_PROC_BROWSER_TEST_F(TwoClientsPasswordManagerSettingMigratorServiceSyncTest,
+ ChangeNewPrefOnMigratedClientOneClientsWithMigration) {
+ ASSERT_TRUE(SetupSync());
+ EnsureMigrationStartsForClient(0);
+ TestPrefChangeOnClient(0, kCredentialsEnableService);
+ ExpectValueOnBothClientsForBothPreference(false);
+}
+
+IN_PROC_BROWSER_TEST_F(
+ TwoClientsPasswordManagerSettingMigratorServiceSyncTest,
+ ChangeNewPrefOnNonMigratedClientOneClientsWithMigration) {
+ ASSERT_TRUE(SetupSync());
+ EnsureMigrationStartsForClient(0);
+ TestPrefChangeOnClient(1, kCredentialsEnableService);
+ ASSERT_TRUE(AwaitBooleanPrefMatches(kPasswordManagerSavingEnabled));
+ ExpectValueOnBothClientsForBothPreference(false);
+}

Powered by Google App Engine
This is Rietveld 408576698