[Smart Lock, Prefs reconciliation] Prefs migration logic for desktop platforms.

components/password_manager/core/common/password_manager_pref_names.cc

Index: components/password_manager/core/common/password_manager_pref_names.cc
diff --git a/components/password_manager/core/common/password_manager_pref_names.cc b/components/password_manager/core/common/password_manager_pref_names.cc
index 340fbfcb97d3e18f0e1af6eb6fd1406a2f8a20ae..2ced7126835df0280bc97d2372b8944e0d225eee 100644
--- a/components/password_manager/core/common/password_manager_pref_names.cc
+++ b/components/password_manager/core/common/password_manager_pref_names.cc
@@ -12,6 +12,8 @@ const char kAllowToCollectURLBubbleWasShown[] =
 const char kAllowToCollectURLBubbleActivePeriodStartFactor[] =
     "password_manager_url_collection_bubble.active_period_start_id";
 
+const char kCredentialEnableService[] = "credentials_enable_service";

[vabr (Chromium), 2015/08/07 08:48:02]

nit: The constant name and value differ (credential vs. credentials). Not a big
deal, but usually they are the same.

Also, it sounds strange as an English phrase, and the role of "service" is not
clear. What about "save_and_fill_credentials"?

[vabr (Chromium), 2015/08/07 09:26:21]

Just to add to the 2nd part of my original comment:
I see that this comes from the existing preference on Android. In that case,
just keep it, sorry for the noise.

(My comment about matching the const name with value still holds, though.)

[engedy, 2015/08/07 11:41:38]

We could consider doing a mapping in PrefModelAssociator to a more reasonable
name that is in the "password_manager.*" namespace, but that's quite obscure,
and I am not sure how well it would be received by the Sync owners.

If we are not going to do that, we should point out in the comment that the name
is as unfortunate as it is because of compatibility reasons with Smart Lock on
Android.

[vabr (Chromium), 2015/08/07 11:56:19]

Please do not undergo such pain just for the name. Being consistent is also
probably better than being an understandable English sentence in this case.
+1

+
 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS) && defined(OS_POSIX)
 const char kLocalProfileId[] = "profile.local_profile_id";
 #endif