[Smart Lock, Prefs reconciliation] Prefs migration logic for desktop platforms.

chrome/browser/password_manager/password_manager_setting_migrater_service.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/password_manager/password_manager_setting_migrater_service.h"
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/prefs/pref_service_syncable.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/sync/profile_sync_service.h"
+#include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "components/keyed_service/content/browser_context_dependency_manager.h"
+#include "components/password_manager/core/common/password_manager_pref_names.h"
+#include "components/sync_driver/sync_service.h"
+#include "content/public/browser/notification_source.h"
+
+namespace {
+
+void ChangeOnePrefBecauseAnotherPrefHasChanged(
+    PrefService* prefs,
+    const std::string& other_pref_name,
+    const std::string& changed_pref_name) {
+  bool changed_pref = prefs->GetBoolean(changed_pref_name.c_str());
+  bool other_pref = prefs->GetBoolean(other_pref_name.c_str());
+  if (changed_pref != other_pref)
+    prefs->SetBoolean(other_pref_name, changed_pref);
+  // TODO(melandory): add histograms in order to track when we can stop
+  // migration.
+}
+
+// Change value of both kPasswordManagerSavingEnabled and
+// kCredentialsEnableService to the |new_value| only if the current value of the
+// pref differs.
+void UpdatePreferencesValuesIfNeeded(PrefService* prefs, bool new_value) {
+  bool legacy_pref_value =
+      prefs->GetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled);
+  bool new_pref_value =
+      prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService);
+  if (legacy_pref_value != new_value) {
+    prefs->SetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled,
+                      new_value);
+  }
+  if (new_pref_value != new_value) {
+    prefs->SetBoolean(password_manager::prefs::kCredentialsEnableService,
+                      new_value);
+  }
+}
+
+void InitCurrentPrefState(PrefService* prefs,
+                          bool* legacy_pref_value,
+                          bool* new_pref_value,
+                          std::vector<bool>* initial_values) {
+  *legacy_pref_value =
+      prefs->GetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled);
+  *new_pref_value =
+      prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService);
+  initial_values->clear();
+  initial_values->push_back(*new_pref_value);

[Nicolas Zea, 2015/09/03 22:44:16]

style_comment: it might be good to have a const int kNewPrefIndex and
kLegacyPrefIndex defined at the top of the file which you then always use to
access/set these values. That might avoid bugs where you accidentally swap the
order of the two due to using push_back

[melandory, 2015/09/04 15:35:26]

I got rid of this vector.

+  initial_values->push_back(*legacy_pref_value);
+}
+
+}  // namespace
+
+PasswordManagerSettingMigraterService::PasswordManagerSettingMigraterService(
+    Profile* profile)
+    : profile_(profile), sync_service_(nullptr) {
+  registrar_.Add(this, chrome::NOTIFICATION_PROFILE_ADDED,
+                 content::Source<Profile>(profile));
+}
+
+PasswordManagerSettingMigraterService::
+    ~PasswordManagerSettingMigraterService() {}
+
+void PasswordManagerSettingMigraterService::Observe(
+    int type,
+    const content::NotificationSource& source,
+    const content::NotificationDetails& details) {
+  DCHECK_EQ(chrome::NOTIFICATION_PROFILE_ADDED, type);
+  if (ProfileSyncServiceFactory::HasProfileSyncService(profile_))
+    sync_service_ = ProfileSyncServiceFactory::GetForProfile(profile_);
+  InitObservers();
+}
+
+void PasswordManagerSettingMigraterService::InitObservers() {
+  PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile_);
+  InitCurrentPrefState(prefs, &initial_legacy_pref_value_,
+                       &initial_new_pref_value_, &initial_values_);
+  pref_change_registrar_.Init(profile_->GetPrefs());
+  pref_change_registrar_.Add(
+      password_manager::prefs::kCredentialsEnableService,
+      base::Bind(&PasswordManagerSettingMigraterService::
+                     OnCredentialsEnableServicePrefChanged,
+                 base::Unretained(this)));
+  pref_change_registrar_.Add(
+      password_manager::prefs::kPasswordManagerSavingEnabled,
+      base::Bind(&PasswordManagerSettingMigraterService::
+                     OnPasswordManagerSavingEnabledPrefChanged,
+                 base::Unretained(this)));
+  if (!(sync_service_ && sync_service_->CanSyncStart())) {
+    PasswordManagerSettingMigraterService::MigrateOffState(prefs);
+  }
+  // This causes OnIsSyncingChanged to be called when the value of
+  // PrefService::IsSyncing() changes.
+  prefs->AddObserver(this);
+}
+
+void PasswordManagerSettingMigraterService::Shutdown() {
+  PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile_);
+  prefs->RemoveObserver(this);
+}
+
+void PasswordManagerSettingMigraterService::
+    OnCredentialsEnableServicePrefChanged(
+        const std::string& changed_pref_name) {
+  PrefService* prefs = profile_->GetPrefs();
+  sync_data_.push_back(
+      prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService));
+  ChangeOnePrefBecauseAnotherPrefHasChanged(
+      prefs, password_manager::prefs::kPasswordManagerSavingEnabled,
+      password_manager::prefs::kCredentialsEnableService);
+}
+
+void PasswordManagerSettingMigraterService::
+    OnPasswordManagerSavingEnabledPrefChanged(
+        const std::string& changed_pref_name) {
+  PrefService* prefs = profile_->GetPrefs();
+  sync_data_.push_back(prefs->GetBoolean(
+      password_manager::prefs::kPasswordManagerSavingEnabled));
+  ChangeOnePrefBecauseAnotherPrefHasChanged(
+      prefs, password_manager::prefs::kCredentialsEnableService,
+      password_manager::prefs::kPasswordManagerSavingEnabled);
+}
+
+void PasswordManagerSettingMigraterService::OnIsSyncingChanged() {
+  LOG(ERROR) << "OnIsSyncingChanged";

[Nicolas Zea, 2015/09/03 22:44:16]

All these LOG(ERROR)'s should probably be DVLOG(1)

[melandory, 2015/09/04 15:35:26]

Sorry, I've accidentally committed it

+  PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile_);
+  if (prefs->IsSyncing() && prefs->IsPrioritySyncing()) {
+    // Initial sync has finished.
+    MigrateAfterModelAssociation(prefs);
+  }
+
+  if (prefs->IsSyncing() == prefs->IsPrioritySyncing()) {
+    // Sync is not in model association step.
+    InitCurrentPrefState(prefs, &initial_legacy_pref_value_,
+                         &initial_new_pref_value_, &initial_values_);
+    sync_data_.clear();
+  }
+}
+
+void PasswordManagerSettingMigraterService::MigrateOffState(
+    PrefService* prefs) {
+  bool new_pref_value =
+      prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService);
+  bool legacy_pref_value =
+      prefs->GetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled);
+  UpdatePreferencesValuesIfNeeded(prefs, new_pref_value && legacy_pref_value);
+}
+
+void PasswordManagerSettingMigraterService::MigrateAfterModelAssociation(
+    PrefService* prefs) {
+  LOG(ERROR) << "MigrateAfterModelAssociation";
+  if (sync_data_.empty()) {
+    MigrateOffState(prefs);
+  } else if (sync_data_.size() == 1) {
+    // Only one value has came from sync. This value should be assigned to both
+    // preferences.
+    UpdatePreferencesValuesIfNeeded(prefs, sync_data_[0]);
+  } else {
+    DCHECK_EQ(2u, initial_values_.size());
+    bool sync_new_pref_value = sync_data_[0];
+    bool sync_legacy_pref_value = sync_data_[sync_data_.size() - 1];
+    if (sync_legacy_pref_value && sync_new_pref_value) {
+      UpdatePreferencesValuesIfNeeded(prefs, true);
+    } else if (!sync_legacy_pref_value && !sync_new_pref_value) {
+      UpdatePreferencesValuesIfNeeded(prefs, false);
+    } else if (!initial_legacy_pref_value_ && !initial_new_pref_value_) {
+      UpdatePreferencesValuesIfNeeded(prefs, true);
+    } else {
+      UpdatePreferencesValuesIfNeeded(prefs, false);
+    }
+  }
+}
+
+// static
+PasswordManagerSettingMigraterService::Factory*
+PasswordManagerSettingMigraterService::Factory::GetInstance() {
+  return Singleton<PasswordManagerSettingMigraterService::Factory>::get();
+}
+
+// static
+PasswordManagerSettingMigraterService*
+PasswordManagerSettingMigraterService::Factory::GetForProfile(
+    Profile* profile) {
+  return static_cast<PasswordManagerSettingMigraterService*>(
+      GetInstance()->GetServiceForBrowserContext(profile, true));
+}
+
+PasswordManagerSettingMigraterService::Factory::Factory()
+    : BrowserContextKeyedServiceFactory(
+          "PasswordManagerSettingMigraterService",
+          BrowserContextDependencyManager::GetInstance()) {
+  DependsOn(ProfileSyncServiceFactory::GetInstance());
+}
+
+PasswordManagerSettingMigraterService::Factory::~Factory() {}
+
+KeyedService*
+PasswordManagerSettingMigraterService::Factory::BuildServiceInstanceFor(
+    content::BrowserContext* context) const {
+  return new PasswordManagerSettingMigraterService(
+      Profile::FromBrowserContext(context));
+}
+
+bool PasswordManagerSettingMigraterService::Factory::
+    ServiceIsCreatedWithBrowserContext() const {
+  return true;
+}