Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Side by Side Diff: chrome/browser/password_manager/password_manager_setting_migrater_service.cc

Issue 1256803002: [Smart Lock, Prefs reconciliation] Prefs migration logic for desktop platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/password_manager/password_manager_setting_migrater_serv ice.h"
6
7 #include "base/bind.h"
8 #include "base/bind_helpers.h"
9 #include "chrome/browser/chrome_notification_types.h"
10 #include "chrome/browser/prefs/pref_service_syncable.h"
11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/sync/profile_sync_service.h"
13 #include "chrome/browser/sync/profile_sync_service_factory.h"
14 #include "components/keyed_service/content/browser_context_dependency_manager.h"
15 #include "components/password_manager/core/common/password_manager_pref_names.h"
16 #include "components/sync_driver/sync_service.h"
17 #include "content/public/browser/notification_source.h"
18
19 namespace {
20
21 void ChangeOnePrefBecauseAnotherPrefHasChanged(
22 PrefService* prefs,
23 const std::string& other_pref_name,
24 const std::string& changed_pref_name) {
25 bool changed_pref = prefs->GetBoolean(changed_pref_name.c_str());
26 bool other_pref = prefs->GetBoolean(other_pref_name.c_str());
27 if (changed_pref != other_pref)
28 prefs->SetBoolean(other_pref_name, changed_pref);
29 // TODO(melandory): add histograms in order to track when we can stop
30 // migration.
31 }
32
33 // Change value of both kPasswordManagerSavingEnabled and
34 // kCredentialsEnableService to the |new_value| only if the current value of the
35 // pref differs.
36 void UpdatePreferencesValuesIfNeeded(PrefService* prefs, bool new_value) {
37 bool legacy_pref_value =
38 prefs->GetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled);
39 bool new_pref_value =
40 prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService);
41 if (legacy_pref_value != new_value) {
42 prefs->SetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled,
43 new_value);
44 }
45 if (new_pref_value != new_value) {
46 prefs->SetBoolean(password_manager::prefs::kCredentialsEnableService,
47 new_value);
48 }
49 }
50
51 void InitCurrentPrefState(PrefService* prefs,
52 bool* legacy_pref_value,
53 bool* new_pref_value,
54 std::vector<bool>* initial_values) {
55 *legacy_pref_value =
56 prefs->GetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled);
57 *new_pref_value =
58 prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService);
59 initial_values->clear();
60 initial_values->push_back(*new_pref_value);
61 initial_values->push_back(*legacy_pref_value);
62 }
63
64 } // namespace
65
66 PasswordManagerSettingMigraterService::PasswordManagerSettingMigraterService(
67 Profile* profile)
68 : profile_(profile), sync_service_(nullptr) {
69 registrar_.Add(this, chrome::NOTIFICATION_PROFILE_ADDED,
70 content::Source<Profile>(profile));
71 }
72
73 PasswordManagerSettingMigraterService::
74 ~PasswordManagerSettingMigraterService() {}
75
76 void PasswordManagerSettingMigraterService::Observe(
77 int type,
78 const content::NotificationSource& source,
79 const content::NotificationDetails& details) {
80 DCHECK_EQ(chrome::NOTIFICATION_PROFILE_ADDED, type);
81 if (ProfileSyncServiceFactory::HasProfileSyncService(profile_))
82 sync_service_ = ProfileSyncServiceFactory::GetForProfile(profile_);
83 InitObservers();
84 }
85
86 void PasswordManagerSettingMigraterService::InitObservers() {
87 PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile_);
88 InitCurrentPrefState(prefs, &initial_legacy_pref_value_,
89 &initial_new_pref_value_, &initial_values_);
90 pref_change_registrar_.Init(profile_->GetPrefs());
91 pref_change_registrar_.Add(
92 password_manager::prefs::kCredentialsEnableService,
93 base::Bind(&PasswordManagerSettingMigraterService::
94 OnCredentialsEnableServicePrefChanged,
95 base::Unretained(this)));
96 pref_change_registrar_.Add(
97 password_manager::prefs::kPasswordManagerSavingEnabled,
98 base::Bind(&PasswordManagerSettingMigraterService::
99 OnPasswordManagerSavingEnabledPrefChanged,
100 base::Unretained(this)));
101 if (!(sync_service_ && sync_service_->CanSyncStart())) {
102 PasswordManagerSettingMigraterService::MigrateOffState(prefs);
103 }
104 // This causes OnIsSyncingChanged to be called when the value of
105 // PrefService::IsSyncing() changes.
106 prefs->AddObserver(this);
107 }
108
109 void PasswordManagerSettingMigraterService::Shutdown() {
110 PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile_);
111 prefs->RemoveObserver(this);
112 }
113
114 void PasswordManagerSettingMigraterService::
115 OnCredentialsEnableServicePrefChanged(
116 const std::string& changed_pref_name) {
117 PrefService* prefs = profile_->GetPrefs();
118 sync_data_.push_back(
119 prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService));
120 ChangeOnePrefBecauseAnotherPrefHasChanged(
121 prefs, password_manager::prefs::kPasswordManagerSavingEnabled,
122 password_manager::prefs::kCredentialsEnableService);
123 }
124
125 void PasswordManagerSettingMigraterService::
126 OnPasswordManagerSavingEnabledPrefChanged(
127 const std::string& changed_pref_name) {
128 PrefService* prefs = profile_->GetPrefs();
129 sync_data_.push_back(prefs->GetBoolean(
130 password_manager::prefs::kPasswordManagerSavingEnabled));
131 ChangeOnePrefBecauseAnotherPrefHasChanged(
132 prefs, password_manager::prefs::kCredentialsEnableService,
133 password_manager::prefs::kPasswordManagerSavingEnabled);
134 }
135
136 void PasswordManagerSettingMigraterService::OnIsSyncingChanged() {
137 PrefServiceSyncable* prefs = PrefServiceSyncable::FromProfile(profile_);
138 if (prefs->IsSyncing() && prefs->IsPrioritySyncing()) {
139 // Initial sync has finished.
140 MigrateAfterModelAssociation(prefs);
141 }
142
143 if (prefs->IsSyncing() == prefs->IsPrioritySyncing()) {
144 // Sync is not in model association step.
145 InitCurrentPrefState(prefs, &initial_legacy_pref_value_,
146 &initial_new_pref_value_, &initial_values_);
147 sync_data_.clear();
148 }
149 }
150
151 void PasswordManagerSettingMigraterService::MigrateOffState(
152 PrefService* prefs) {
153 bool new_pref_value =
154 prefs->GetBoolean(password_manager::prefs::kCredentialsEnableService);
155 bool legacy_pref_value =
156 prefs->GetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled);
157 UpdatePreferencesValuesIfNeeded(prefs, new_pref_value && legacy_pref_value);
158 }
159
160 void PasswordManagerSettingMigraterService::MigrateAfterModelAssociation(
161 PrefService* prefs) {
162 if (sync_data_.empty()) {
163 MigrateOffState(prefs);
164 } else if (sync_data_.size() == 1) {
165 // Only one value has came from sync. This value should be assigned to both
166 // preferences.
167 UpdatePreferencesValuesIfNeeded(prefs, sync_data_[0]);
168 } else {
169 DCHECK_EQ(2u, initial_values_.size());
170 bool sync_new_pref_value = sync_data_[0];
171 bool sync_legacy_pref_value = sync_data_[sync_data_.size() - 1];
172 if (sync_legacy_pref_value && sync_new_pref_value) {
173 UpdatePreferencesValuesIfNeeded(prefs, true);
174 } else if (!sync_legacy_pref_value && !sync_new_pref_value) {
175 UpdatePreferencesValuesIfNeeded(prefs, false);
176 } else if (!initial_legacy_pref_value_ && !initial_new_pref_value_) {
177 UpdatePreferencesValuesIfNeeded(prefs, true);
178 } else {
179 UpdatePreferencesValuesIfNeeded(prefs, false);
180 }
181 }
182 }
183
184 // static
185 PasswordManagerSettingMigraterService::Factory*
186 PasswordManagerSettingMigraterService::Factory::GetInstance() {
187 return Singleton<PasswordManagerSettingMigraterService::Factory>::get();
188 }
189
190 // static
191 PasswordManagerSettingMigraterService*
192 PasswordManagerSettingMigraterService::Factory::GetForProfile(
193 Profile* profile) {
194 return static_cast<PasswordManagerSettingMigraterService*>(
195 GetInstance()->GetServiceForBrowserContext(profile, true));
196 }
197
198 PasswordManagerSettingMigraterService::Factory::Factory()
199 : BrowserContextKeyedServiceFactory(
200 "PasswordManagerSettingMigraterService",
201 BrowserContextDependencyManager::GetInstance()) {
202 DependsOn(ProfileSyncServiceFactory::GetInstance());
203 }
204
205 PasswordManagerSettingMigraterService::Factory::~Factory() {}
206
207 KeyedService*
208 PasswordManagerSettingMigraterService::Factory::BuildServiceInstanceFor(
209 content::BrowserContext* context) const {
210 return new PasswordManagerSettingMigraterService(
211 Profile::FromBrowserContext(context));
212 }
213
214 bool PasswordManagerSettingMigraterService::Factory::
215 ServiceIsCreatedWithBrowserContext() const {
216 return true;
217 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698