[Smart Lock, Prefs reconciliation] Prefs migration logic for desktop platforms.

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 51 matching lines @@
 #include "chrome/browser/gpu/three_d_api_observer.h"
 #include "chrome/browser/media/media_capture_devices_dispatcher.h"
 #include "chrome/browser/memory/oom_priority_manager.h"
 #include "chrome/browser/metrics/field_trial_synchronizer.h"
 #include "chrome/browser/metrics/metrics_services_manager.h"
 #include "chrome/browser/metrics/thread_watcher.h"
 #include "chrome/browser/metrics/variations/variations_service.h"
 #include "chrome/browser/nacl_host/nacl_browser_delegate_impl.h"
 #include "chrome/browser/net/chrome_net_log.h"
 #include "chrome/browser/net/crl_set_fetcher.h"
+#include "chrome/browser/password_manager/password_manager_migration_service.h"
 #include "chrome/browser/performance_monitor/performance_monitor.h"
 #include "chrome/browser/plugins/plugin_prefs.h"
 #include "chrome/browser/power/process_power_collector.h"
 #include "chrome/browser/pref_service_flags_storage.h"
 #include "chrome/browser/prefs/chrome_pref_service_factory.h"
 #include "chrome/browser/prefs/command_line_pref_store.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/prefs/pref_metrics_service.h"
 #include "chrome/browser/printing/cloud_print/cloud_print_proxy_service.h"
 #include "chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h"
@@ skipping 1473 matching lines @@
 
 #if !defined(DISABLE_NACL)
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(nacl::NaClProcessHost::EarlyStartup));
 #endif  // !defined(DISABLE_NACL)
 
   // Make sure initial prefs are recorded
   PrefMetricsService::Factory::GetForProfile(profile_);
+  password_manager::PasswordSettingsMigrationService::Factory::GetForProfile(

[vabr (Chromium), 2015/08/07 08:48:02]

nit: Add a blank line above this line, otherwise it looks like it is part of
recording the initial prefs.

[engedy, 2015/08/07 11:41:38]

It might be just that I have already forgotten why it was impossible, but now it
seems to be that it should be possible to rely on
ServiceIsCreatedWithBrowserContext() and remove this line.

That way, we would add a reference to the factory into
ChromeBrowserMainExtraPartsProfiles::
EnsureBrowserContextKeyedServiceFactoriesBuilt(), and given the DependsOn()
directives, the settings migrater service would be magically created after the
ProfileSyncService.

I am not entirely sure, however, which scenarios there are when we do not have a
ProfileSyncService, and what the DependsOn directive will result in in those
cases. Could you please explain this to me?

[melandory, 2015/08/07 15:05:18]

Before my concern was more emperical, I was getting
ProfileSyncServiceFactory::HasProfileSyncService(profile_) false on the time
ofPasswordSettingsMigrationService  construction.

I investigated a bit more, it looks like I'm hitting
https://code.google.com/p/chromium/issues/detail?id=171406

I'll check what's can be done here.

[melandory, 2015/08/12 09:03:23]

Done.

+      profile_);
 
   PreBrowserStart();
 
   // Instantiate the notification UI manager, as this triggers a perf timer
   // used to measure startup time. TODO(stevenjb): Figure out what is actually
   // triggering the timer and call that explicitly in the approprate place.
   // http://crbug.com/105065.
   browser_process_->notification_ui_manager();
 
   // This must be called prior to RegisterComponentsForUpdate, in case the CLD
@@ skipping 227 matching lines @@
   chromeos::CrosSettings::Shutdown();
 #endif  // defined(OS_CHROMEOS)
 #endif  // defined(OS_ANDROID)
 }
 
 // Public members:
 
 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
   chrome_extra_parts_.push_back(parts);
 }