webkit/plugins/ppapi/ppapi_plugin_instance.cc - Issue 12568010: Cleanup: Make gamepad API consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.cc

Issue 12568010: Cleanup: Make gamepad API consistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc

diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.cc b/webkit/plugins/ppapi/ppapi_plugin_instance.cc

index 886338b1f4b286fd204d2506ad1158c02994daa5..0d740766ce9beab0684f4513d06d628c421223c9 100644

--- a/webkit/plugins/ppapi/ppapi_plugin_instance.cc

+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.cc

@@ -327,7 +327,8 @@ PPB_Gamepad_API* PluginInstance::GamepadImpl::AsPPB_Gamepad_API() {

return this;

}

-void PluginInstance::GamepadImpl::Sample(PP_GamepadsSampleData* data) {

+void PluginInstance::GamepadImpl::Sample(PP_Instance instance,

dmichael (off chromium) 2013/03/19 19:01:06 nit: we usually omit or put the param name in /**/

teravest 2013/03/19 19:39:33 Done.

+ PP_GamepadsSampleData* data) {

WebKit::WebGamepads webkit_data;

delegate_->SampleGamepads(&webkit_data);

ConvertWebKitGamepadData(