Cleanup: Make gamepad API consistent.

Cleanup: Make gamepad API consistent.

In the "old proxy model", using EnterInstance<>, code always passed the
instance as the first argument. In the "new proxy model", using
EnterInstanceAPI<>, code is inconsistent, making it hard to automatically
generate thunk files from IDL.

This change updates the gamepad API to be consistent with many other interfaces
and the old proxy model.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189169

[raymes, 2013-03-19 18:17:39]

lgtm thanks!

[commit-bot: I haz the power, 2013-03-19 18:22:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/12568010/1

[commit-bot: I haz the power, 2013-03-19 18:22:14]

Presubmit check for 12568010-1 failed and returned exit status 1.

INFO:root:Found 6 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ppapi/PRESUBMIT.py

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ppapi/thunk/ppb_gamepad_thunk.cc
    ppapi/proxy/gamepad_resource.h
    ppapi/proxy/gamepad_resource.cc
    webkit/plugins/ppapi/ppapi_plugin_instance.cc
    webkit/plugins/ppapi/ppapi_plugin_instance.h
    ppapi/thunk/ppb_gamepad_api.h

Presubmit checks took 1.2s to calculate.

[dmichael (off chromium), 2013-03-19 19:01:06]

lgtm

https://codereview.chromium.org/12568010/diff/1/ppapi/proxy/gamepad_resource.cc
File ppapi/proxy/gamepad_resource.cc (right):

https://codereview.chromium.org/12568010/diff/1/ppapi/proxy/gamepad_resource....
ppapi/proxy/gamepad_resource.cc:65: void GamepadResource::Sample(PP_Instance
instance,
see other nit

https://codereview.chromium.org/12568010/diff/1/webkit/plugins/ppapi/ppapi_pl...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

https://codereview.chromium.org/12568010/diff/1/webkit/plugins/ppapi/ppapi_pl...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:330: void
PluginInstance::GamepadImpl::Sample(PP_Instance instance,
nit: we usually omit or put the param name in /**/ if it's unused. Not sure if
Windows warns or it's just a good habit...

[teravest, 2013-03-19 19:39:33]

https://codereview.chromium.org/12568010/diff/1/ppapi/proxy/gamepad_resource.cc
File ppapi/proxy/gamepad_resource.cc (right):

https://codereview.chromium.org/12568010/diff/1/ppapi/proxy/gamepad_resource....
ppapi/proxy/gamepad_resource.cc:65: void GamepadResource::Sample(PP_Instance
instance,
On 2013/03/19 19:01:06, dmichael wrote:
> see other nit

Done.

https://codereview.chromium.org/12568010/diff/1/webkit/plugins/ppapi/ppapi_pl...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

https://codereview.chromium.org/12568010/diff/1/webkit/plugins/ppapi/ppapi_pl...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:330: void
PluginInstance::GamepadImpl::Sample(PP_Instance instance,
On 2013/03/19 19:01:06, dmichael wrote:
> nit: we usually omit or put the param name in /**/ if it's unused. Not sure if
> Windows warns or it's just a good habit...

Done.

[commit-bot: I haz the power, 2013-03-19 19:54:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/12568010/7001

[commit-bot: I haz the power, 2013-03-20 00:17:38]

Change committed as 189169