Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 12568009: Merge 145735 "REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit war… (Closed)

Created:
7 years, 9 months ago by Nate Chapin
Modified:
7 years, 9 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 145735 "REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning" > .: Expose symbols for internals > https://bugs.webkit.org/show_bug.cgi?id=112194 > > Reviewed by Alexey Proskuryakov. > > * Source/autotools/symbols.filter: > > Source/WebCore: REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning > https://bugs.webkit.org/show_bug.cgi?id=112194 > > Reviewed by Alexey Proskuryakov. > > Test: http/tests/navigation/post-redirect-get-reload.php > > * loader/SubresourceLoader.cpp: > (WebCore::SubresourceLoader::willSendRequest): Matching urls aren't a reliable way of checking whether > we are in a redirect. Check redirectResponse.isNull() instead. > * testing/Internals.cpp: > (WebCore::Internals::forceReload): Expose a means of forcing a reload like one a user generates for testing. > Note that testRunner.queueReload() does this, but is not supported after the initial load completes, > which makes it unsuitable for this case. > * testing/Internals.h: > * testing/Internals.idl: > > Source/WebKit/win: Expose symbols for internals > https://bugs.webkit.org/show_bug.cgi?id=112194 > > Reviewed by Alexey Proskuryakov. > > * WebKit.vcproj/WebKitExports.def.in: > > LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=112194. > > Reviewed by Alexey Proskuryakov. > > * http/tests/navigation/post-redirect-get-reload-expected.txt: Added. > * http/tests/navigation/post-redirect-get-reload.php: Added. > TBR=japhet@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, --1 lines) Patch
A + LayoutTests/http/tests/navigation/post-redirect-get-reload.php View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/navigation/post-redirect-get-reload-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/loader/SubresourceLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/testing/Internals.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/autotools/symbols.filter View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nate Chapin
7 years, 9 months ago (2013-03-19 18:11:10 UTC) #1
Nate Chapin
7 years, 9 months ago (2013-03-19 18:11:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r146223.

Powered by Google App Engine
This is Rietveld 408576698