Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: ui/wm/BUILD.gn

Issue 1256793011: GN: Add missing dependency for wm_unittests on ui_test_pak (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/wm/BUILD.gn
diff --git a/ui/wm/BUILD.gn b/ui/wm/BUILD.gn
index 80a5b657eaabfc324b86b258abe698856506aeb1..cc41f99e9628198b684f0777474723b1d495ada1 100644
--- a/ui/wm/BUILD.gn
+++ b/ui/wm/BUILD.gn
@@ -152,6 +152,7 @@ test("wm_unittests") {
data = [
"$root_out_dir/ui_test.pak",
brettw 2015/07/31 20:46:23 It seems like this line should be unnecessary now.
agrieve 2015/08/05 00:43:40 Done - is it always an error to list a file within
brettw 2015/08/05 00:58:55 No, but generally a data file should be listed onc
]
+ data_deps = [ "//ui/resources:ui_test_pak" ]
deps = [
":test_support",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698