Issue 1256793008: Remove unused params in WebSocketHandshakeStreamCreateHelperTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1256793008: Remove unused params in WebSocketHandshakeStreamCreateHelperTest (Closed)

Created:
5 years, 4 months ago by Adam Rice

Modified:
5 years, 4 months ago

Reviewers:
tyoshino (SeeGerritForStatus)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove unused params in WebSocketHandshakeStreamCreateHelperTest Several parameters to WebSocketHandshakeStreamCreateHelperTest::CreateAndInitializeStream() were always passed the same values. Remove them. BUG= TEST=net_unittests Committed: https://crrev.com/8c1d9ec45775e3d20e4bb596221b9dcd37dcdd04 Cr-Commit-Position: refs/heads/master@{#340676}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -17 lines)			Patch
	M	net/websockets/websocket_handshake_stream_create_helper_test.cc	View		7 chunks	+10 lines, -17 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256793008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256793008/1

5 years, 4 months ago (2015-07-28 12:45:56 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-07-28 14:13:04 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8c1d9ec45775e3d20e4bb596221b9dcd37dcdd04
Cr-Commit-Position: refs/heads/master@{#340676}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages