use_x11==1 is a better condition for xdisplaycheck dep

use_x11==1 is a better condition for xdisplaycheck dep

The previous condition was incorrect when building for
embedded linux without using the ozone porting layer.
use_x11==1 is used everywhere else for the xdisplaycheck
depdendency, let's do the same here.

Committed: https://crrev.com/b25899d3a756307c8c320472b484e7fbb56295c3
Cr-Commit-Position: refs/heads/master@{#340376}

[Mostyn Bramley-Moore, 2015-07-24 08:26:36]

mostynb@opera.com changed reviewers:
+ jamesr@chromium.org

[Mostyn Bramley-Moore, 2015-07-24 08:27:08]

@jamesr: please take a look at this tiny gyp fixup.

[jamesr, 2015-07-24 17:41:07]

-jamesr from reviewers list

you should ask an OWNER of this code to look at it

[jamesr, 2015-07-24 17:41:19]

jamesr@chromium.org changed reviewers:
- jamesr@chromium.org

[danakj, 2015-07-24 20:17:00]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-07-24 20:17:01]

When is the old check wrong?

[Mostyn Bramley-Moore, 2015-07-24 21:06:39]

On 2015/07/24 20:17:01, danakj wrote:
> When is the old check wrong?

The check is wrong when building for embedded linux (which does not use X11) but
without using ozone.  If you do something like "git grep -B 3 xdisplaycheck" you
will see the condition use_x11==1 used everywhere else (as far as I can see) for
this dependency.

(BTW jamesr is one of the cc/OWNERS - should he be removed from there?)

[danakj, 2015-07-24 21:13:17]

On 2015/07/24 21:06:39, Mostyn Bramley-Moore wrote:
> On 2015/07/24 20:17:01, danakj wrote:
> > When is the old check wrong?
> 
> The check is wrong when building for embedded linux (which does not use X11)
but
> without using ozone.  If you do something like "git grep -B 3 xdisplaycheck"
you
> will see the condition use_x11==1 used everywhere else (as far as I can see)
for
> this dependency.

Can you say this in your patch description? Then LGTM

> (BTW jamesr is one of the cc/OWNERS - should he be removed from there?)

If he doesn't want to do any reviews anymore, ya I guess. You can ask him?

[danakj, 2015-07-24 21:19:24]

On Fri, Jul 24, 2015 at 2:13 PM, <danakj@chromium.org> wrote:

> On 2015/07/24 21:06:39, Mostyn Bramley-Moore wrote:
>
>> On 2015/07/24 20:17:01, danakj wrote:
>> > When is the old check wrong?
>>
>
>  The check is wrong when building for embedded linux (which does not use
>> X11)
>>
> but
>
>> without using ozone.  If you do something like "git grep -B 3
>> xdisplaycheck"
>>
> you
>
>> will see the condition use_x11==1 used everywhere else (as far as I can
>> see)
>>
> for
>
>> this dependency.
>>
>
> Can you say this in your patch description? Then LGTM
>
>  (BTW jamesr is one of the cc/OWNERS - should he be removed from there?)
>>
>
> If he doesn't want to do any reviews anymore, ya I guess. You can ask him?
>

Actually, I'll ask, thanks for bringing it up.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mostyn Bramley-Moore, 2015-07-24 21:44:39]

On 2015/07/24 21:19:24, danakj wrote:
> > Can you say this in your patch description? Then LGTM

Done.

> >  (BTW jamesr is one of the cc/OWNERS - should he be removed from there?)
> >>
> >
> > If he doesn't want to do any reviews anymore, ya I guess. You can ask him?
> >
> 
> Actually, I'll ask, thanks for bringing it up.

No problem- I emailed him before I saw this.

[Mostyn Bramley-Moore, 2015-07-24 21:44:47]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-24 21:45:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1256793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1256793002/1

[commit-bot: I haz the power, 2015-07-24 22:48:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-24 22:48:55]

Dry run: This issue passed the CQ dry run.

[Mostyn Bramley-Moore, 2015-07-24 23:23:22]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2015-07-24 23:24:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1256793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1256793002/1

[commit-bot: I haz the power, 2015-07-24 23:29:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-24 23:30:29]

Patchset 1 (id:??) landed as
https://crrev.com/b25899d3a756307c8c320472b484e7fbb56295c3
Cr-Commit-Position: refs/heads/master@{#340376}