tools/gn/BUILD.gn - Issue 1256783007: Rename iterator debugging flag in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/BUILD.gn

Issue 1256783007: Rename iterator debugging flag in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/BUILD.gn

diff --git a/tools/gn/BUILD.gn b/tools/gn/BUILD.gn

index 39fee93ab4014b57400a7eb9a78f48fd16645ea9..68c30ea5acf3b86c83e352bd17542aafb0e113c3 100644

--- a/tools/gn/BUILD.gn

+++ b/tools/gn/BUILD.gn

@@ -214,6 +214,11 @@ action("last_commit_position") {

]

}

+# Note for Windows debugging: GN is super-multithreaded and uses a lot of STL.

+# Iterator debugging on Windows does locking for every access, which ends up

+# slowing down debug runtime from 0:36 to 9:40. If you want to run debug builds

+# of GN over the large Chrome build, you will want to set the arg:

+# enable_iterator_debugging = false

executable("gn") {

sources = [

"gn_main.cc",

« no previous file with comments | « build/config/BUILD.gn ('k') | tools/gn/docs/cookbook.md » ('j') | no next file with comments »