Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1256783007: Rename iterator debugging flag in GN. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename iterator debugging flag in GN. Convert from "disable"=true to "enable"=false for clarity. Add hints to GN build for debugging. Removed the !is_android check in the iterator debugging. This is redundant with the is_linux check (is_linux used to be set for Android which is why this code got written). Committed: https://crrev.com/e134d6c0f0f778251e38615bda7b241f077c5455 Cr-Commit-Position: refs/heads/master@{#341608}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M build/config/BUILD.gn View 2 chunks +14 lines, -9 lines 0 comments Download
M tools/gn/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/gn/docs/cookbook.md View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
brettw
I was using this flag to debug on Windows and the double-negative was making it ...
5 years, 4 months ago (2015-08-03 20:06:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256783007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256783007/1
5 years, 4 months ago (2015-08-03 20:07:03 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/80596) ios_dbg_simulator_ninja on ...
5 years, 4 months ago (2015-08-03 20:09:13 UTC) #6
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-03 20:12:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256783007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256783007/20001
5 years, 4 months ago (2015-08-03 20:38:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-03 21:06:21 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 21:06:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e134d6c0f0f778251e38615bda7b241f077c5455
Cr-Commit-Position: refs/heads/master@{#341608}

Powered by Google App Engine
This is Rietveld 408576698