Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1256783002: X87: [interpreter] Add basic framework for bytecode handler code generation. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [interpreter] Add basic framework for bytecode handler code generation. port 7877c4e0c77b5c2b97678406eab7e9ad6eba4a4d (r29814). original commit message: Adds basic support for generation of interpreter bytecode handler code snippets. The InterpreterAssembler class exposes a set of low level, interpreter specific operations which can be used to build a Turbofan graph. The Interpreter class generates a bytecode handler snippet for each bytecode by assembling operations using an InterpreterAssembler. Currently only two simple bytecodes are supported: LoadLiteral0 and Return. BUG= Committed: https://crrev.com/c4cd117e2d12c460642591c7a9314449ebd8e625 Cr-Commit-Position: refs/heads/master@{#29838}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/compiler/x87/linkage-x87.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-24 09:28:37 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-24 09:32:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256783002/20001
5 years, 5 months ago (2015-07-24 09:32:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-24 10:03:19 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 10:03:34 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4cd117e2d12c460642591c7a9314449ebd8e625
Cr-Commit-Position: refs/heads/master@{#29838}

Powered by Google App Engine
This is Rietveld 408576698