Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1256763005: Fix for GrAtlasTextContext crash (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/gpu/GrAtlasTextBlob.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
joshualitt
a small patch, ptal.
5 years, 4 months ago (2015-07-29 16:52:07 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/1256763005/diff/1/src/gpu/GrAtlasTextBlob.h File src/gpu/GrAtlasTextBlob.h (right): https://codereview.chromium.org/1256763005/diff/1/src/gpu/GrAtlasTextBlob.h#newcode101 src/gpu/GrAtlasTextBlob.h:101: // Forward glyph / vertex information to seed ...
5 years, 4 months ago (2015-07-29 17:00:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256763005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256763005/40001
5 years, 4 months ago (2015-07-29 17:05:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256763005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256763005/40001
5 years, 4 months ago (2015-07-29 17:41:03 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 18:10:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/e43e3bdd6d7a49623496331a17344a76d04caa7e

Powered by Google App Engine
This is Rietveld 408576698