Issue 125673003: dbus: Add comments about the right way to expose methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125673003: dbus: Add comments about the right way to expose methods (Closed)

Created:
6 years, 11 months ago by satorux1

Modified:
6 years, 11 months ago

Reviewers:
hashimoto

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

dbus: Add comments about the right way to expose methods Along the way, fix the order in the test service used in unit tests. BUG=332120 TEST=dbus_unittests pass as before Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243770

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -12 lines)			Patch
M	dbus/bus.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	dbus/exported_object.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	dbus/test_service.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dbus/test_service.cc	View	5 chunks	+14 lines, -11 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/125673003/1

6 years, 11 months ago (2014-01-08 04:12:11 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243033

6 years, 11 months ago (2014-01-08 05:14:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/125673003/1

6 years, 11 months ago (2014-01-09 01:13:46 UTC) #5

Message was sent while issue was closed.

Change committed as 243770