Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1256693002: Disable failing simdjs tests. (Closed)

Created:
5 years, 5 months ago by bbudge
Modified:
5 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable failing simdjs tests. These benchmarks are not updated to the latest spec and polyfill. R=machenbach@chromium.org LOG=N BUG=v8:4124 Committed: https://crrev.com/a02219e97e89e6d63cfcfb4a076433f2b6c7ff7a Cr-Commit-Position: refs/heads/master@{#29853}

Patch Set 1 #

Patch Set 2 : Missed two files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -68 lines) Patch
M test/simdjs/SimdJs.json View 1 3 chunks +0 lines, -68 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
bbudge
5 years, 5 months ago (2015-07-24 01:05:45 UTC) #1
bbudge
I thought the simdjs.status file could cause tests to skip. It's no problem removing these ...
5 years, 5 months ago (2015-07-24 12:50:27 UTC) #2
Michael Achenbach
lgtm
5 years, 5 months ago (2015-07-24 14:48:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256693002/20001
5 years, 5 months ago (2015-07-24 14:51:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-24 15:03:53 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 15:04:09 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a02219e97e89e6d63cfcfb4a076433f2b6c7ff7a
Cr-Commit-Position: refs/heads/master@{#29853}

Powered by Google App Engine
This is Rietveld 408576698