Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1256673003: Add more NT interceptor stuff to the WinASan blacklist (Closed)

Created:
5 years, 5 months ago by Reid Kleckner
Modified:
5 years, 5 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more NT interceptor stuff to the WinASan blacklist This is enough to get sandbox_integration_tests to pass with ASan. Previously this code was compiled by MSVC because it lives in files that use SEH. Now that Clang can compile SEH, we have to extend the blacklist to avoid instrumentation. R=timurrrr@chromium.org BUG=459166 Committed: https://crrev.com/b67214af63fde1d90a54f892621f9e8f2ebc0df9 Cr-Commit-Position: refs/heads/master@{#340195}

Patch Set 1 #

Patch Set 2 : Fix copy-pasto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/memory/asan/blacklist_win.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Reid Kleckner
5 years, 5 months ago (2015-07-23 22:21:36 UTC) #1
Reid Kleckner
Fix copy-pasto
5 years, 5 months ago (2015-07-23 22:24:19 UTC) #2
Timur Iskhodzhanov
lgtm
5 years, 5 months ago (2015-07-23 22:25:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256673003/20001
5 years, 5 months ago (2015-07-23 22:25:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-23 22:46:14 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 22:47:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b67214af63fde1d90a54f892621f9e8f2ebc0df9
Cr-Commit-Position: refs/heads/master@{#340195}

Powered by Google App Engine
This is Rietveld 408576698