Add tracing for GL texture objects

content/common/host_shared_bitmap_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/host_shared_bitmap_manager.h"
 
 #include "base/lazy_instance.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/trace_event/process_memory_dump.h"
@@ skipping 137 matching lines @@
 
   return make_scoped_ptr(new HostSharedBitmap(
       static_cast<uint8*>(data->memory->memory()), data, id, nullptr));
 }
 
 bool HostSharedBitmapManager::OnMemoryDump(
     base::trace_event::ProcessMemoryDump* pmd) {
   base::AutoLock lock(lock_);
 
   for (const auto& bitmap : handle_map_) {
-    base::trace_event::MemoryAllocatorDump* dump = pmd->CreateAllocatorDump(
-        base::StringPrintf("%s/%s", kMemoryAllocatorName,
-                           base::HexEncode(bitmap.first.name,
-                                           sizeof(bitmap.first.name)).c_str()));
+    base::trace_event::MemoryAllocatorDump* dump =
+        pmd->CreateAllocatorDump(base::StringPrintf(
+            "%s/%s", kMemoryAllocatorName,

[reveman, 2015/07/28 21:38:49]

while here, can you remove the kMemoryAllocatorName constant and just put the
name in here? more consistent with other memory dump providers.

[ericrk, 2015/07/29 18:46:46]

Done.

+            base::HexEncode(bitmap.first.name, sizeof(bitmap.first.name))
+                .c_str()));
     if (!dump)
       return false;
 
     dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
                     base::trace_event::MemoryAllocatorDump::kUnitsBytes,
                     bitmap.second->buffer_size);
+
+    // Generate a global GUID used to share this allocation with the GPU
+    // process.

[reveman, 2015/07/28 21:38:49]

not shared with GPU process. only shared with renderer processes.

[ericrk, 2015/07/29 18:46:46]

yup, got a little to copy-pasty.

+    auto guid = cc::GetSharedBitmapGUIDForTracing(bitmap.first);
+    pmd->CreateSharedGlobalAllocatorDump(guid);
+    pmd->AddOwnershipEdge(dump->guid(), guid);
   }
 
   return true;
 }
 
 void HostSharedBitmapManager::ChildAllocatedSharedBitmap(
     size_t buffer_size,
     const base::SharedMemoryHandle& handle,
     base::ProcessHandle process_handle,
     const cc::SharedBitmapId& id) {
@@ skipping 56 matching lines @@
   return handle_map_.size();
 }
 
 void HostSharedBitmapManager::FreeSharedMemoryFromMap(
     const cc::SharedBitmapId& id) {
   base::AutoLock lock(lock_);
   handle_map_.erase(id);
 }
 
 }  // namespace content