Add tracing for GL texture objects

cc/resources/shared_bitmap.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/shared_bitmap.h"
 
 #include "base/logging.h"
 #include "base/numerics/safe_math.h"
 #include "base/rand_util.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/stringprintf.h"
 
 namespace cc {
 
 SharedBitmap::SharedBitmap(uint8* pixels, const SharedBitmapId& id)
     : pixels_(pixels), id_(id) {
 }
 
 SharedBitmap::~SharedBitmap() {
 }
 
@@ skipping 39 matching lines @@
 }
 
 // static
 SharedBitmapId SharedBitmap::GenerateId() {
   SharedBitmapId id;
   // Needs cryptographically-secure random numbers.
   base::RandBytes(id.name, sizeof(id.name));
   return id;
 }
 
+base::trace_event::MemoryAllocatorDumpGuid GetSharedBitmapGUIDForTracing(
+    const SharedBitmapId& bitmap_id) {
+  auto bitmap_id_hex = base::HexEncode(bitmap_id.name, sizeof(bitmap_id.name));

[ssid, 2015/07/29 11:17:43]

Please add a line  pmd->CreateSharedGlobalAllocatorDump(created_guid); here, as
I said in the other comment.

[ericrk, 2015/07/29 18:46:46]

We've currently been doing this at the call-site (added it to
resource_provider.cc... we could re-factor all of these to do it at GUID
generation... might be cleaner - what do you think?

+  return base::trace_event::MemoryAllocatorDumpGuid(base::StringPrintf(
+      "gpumemorybuffer-x-process/%s", bitmap_id_hex.c_str()));

[ericrk, 2015/07/28 21:02:32]

These IDs are globally unique already right? SharedBitmapManager doesn't track
clients/child process IDs directly, so we'd need some more plumbing if that is
required.

[reveman, 2015/07/28 21:38:49]

s/gpumemorybuffer-x-process/sharedbitmap-x-process/

[petrcermak, 2015/07/29 16:13:34]

Yest, the IDs are globally unique.

[ericrk, 2015/07/29 18:46:46]

Done.

+}
+
 }  // namespace cc