Issue 12566031: Merge 186312

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12566031: Merge 186312 (Closed)

Created:
7 years, 9 months ago by yosin_UTC9

Modified:
7 years, 9 months ago

Reviewers:
yosin_UTC9

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1410/src/

Visibility:
Public.

More Reviews

Description

Merge 186312 > Bookmark manager: Handle "copy", "cut"and "paste" events only when list or tree pane active. > > This caused by a change of getSelectedBookmarkNodes() in r172230. Before r177230, getSelectedBookmarkNodes() threw error unless list or tree is active. From r177230, getSelectedBookmarkNodes() returns selected items of list when list nor tree is active. > > Note: For a11y, when context menu or organize menu is open, menu takes focus. So, list/tree is no more active element when menu is opened. > > This causes "cut" event handler of document object does "cut" operation on an active item of list. In bug case, an active item is editing bookmark. > > This patch changes to check active element in "copy", "cut", and "paste" event handler. > > BUG=174613 > TEST=On bookmark manager, edit/rename bookmark/folder and hit Ctrl+X in edit field. > > Review URL: https://codereview.chromium.org/12387036 TBR=yosin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187479

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/resources/bookmark_manager/js/main.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r187479.

Expand Messages | Collapse Messages