Issue 12566012: Change analyzer to not complain about string+string.

Issue 12566012: Change analyzer to not complain about string+string. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
floitsch, scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change analyzer to not complain about string+string. Committed: https://code.google.com/p/dart/source/detail?r=19792

Patch Set 2 : Make test that should fail also do so. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -37 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View		19 chunks	+18 lines, -30 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

I hope LGTM. https://codereview.chromium.org/12566012/diff/1/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java (right): https://codereview.chromium.org/12566012/diff/1/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java#newcode1215 compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java:1215: analyze("var c = 'foo' + 1;"); ...

7 years, 9 months ago (2013-03-11 13:30:38 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #2 manually as r19792 (presubmit successful).

7 years, 9 months ago (2013-03-11 13:56:28 UTC) #3

Lasse Reichstein Nielsen

7 years, 9 months ago (2013-03-12 11:43:39 UTC) #5

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/12566012/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
(right):

https://chromiumcodereview.appspot.com/12566012/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java:1215:
analyze("var c = 'foo' + 1;");
Good catch. That's exactly what we want to be a warning.

Expand Messages | Collapse Messages