Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: src/objects.cc

Issue 12566004: fix uninitialized variable (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 reinterpret_cast<uintptr_t>(descriptor.compare_value); 208 reinterpret_cast<uintptr_t>(descriptor.compare_value);
209 uintptr_t value = *CheckedCast<uintptr_t>(ptr); 209 uintptr_t value = *CheckedCast<uintptr_t>(ptr);
210 return heap->ToBoolean(compare_value == value); 210 return heap->ToBoolean(compare_value == value);
211 } 211 }
212 212
213 213
214 static MaybeObject* GetPrimitiveValue( 214 static MaybeObject* GetPrimitiveValue(
215 const PrimitiveValueDescriptor& descriptor, 215 const PrimitiveValueDescriptor& descriptor,
216 char* ptr, 216 char* ptr,
217 Heap* heap) { 217 Heap* heap) {
218 int32_t int32_value; 218 int32_t int32_value = 0;
219 switch (descriptor.data_type) { 219 switch (descriptor.data_type) {
220 case kDescriptorInt8Type: 220 case kDescriptorInt8Type:
221 int32_value = *CheckedCast<int8_t>(ptr); 221 int32_value = *CheckedCast<int8_t>(ptr);
222 break; 222 break;
223 case kDescriptorUint8Type: 223 case kDescriptorUint8Type:
224 int32_value = *CheckedCast<uint8_t>(ptr); 224 int32_value = *CheckedCast<uint8_t>(ptr);
225 break; 225 break;
226 case kDescriptorInt16Type: 226 case kDescriptorInt16Type:
227 int32_value = *CheckedCast<int16_t>(ptr); 227 int32_value = *CheckedCast<int16_t>(ptr);
228 break; 228 break;
(...skipping 14066 matching lines...) Expand 10 before | Expand all | Expand 10 after
14295 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 14295 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
14296 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 14296 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
14297 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 14297 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
14298 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 14298 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
14299 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 14299 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
14300 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 14300 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
14301 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 14301 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
14302 } 14302 }
14303 14303
14304 } } // namespace v8::internal 14304 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698