Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: .gn

Issue 1256593003: Gets gn check to execute cleanly in mojo/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: attempt 2 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: .gn
diff --git a/.gn b/.gn
index cfebd67c634363bf280d6c5cd629f43d735395c0..8068622daeb9c10d14906efa33aa2c7d9aa1ce0d 100644
--- a/.gn
+++ b/.gn
@@ -75,9 +75,7 @@ check_targets = [
"mojo/application/*",
"mojo/build/*",
"mojo/cc/*",
-
- # TODO(sky): resolve this.
- # "mojo/common/*",
+ "mojo/common/*",
"mojo/converters/*",
"mojo/environment/*",
« no previous file with comments | « no previous file | mojo/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698