Avoid creating illegal symbols in symbol_conflict_test.

Avoid creating illegal symbols in symbol_conflict_test.

Fixes #23870.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/926525dab05cf49dd2935110bffcc3d8026ade3f

[Paul Berry, 2015-07-23 16:21:36]

paulberry@google.com changed reviewers:
+ floitsch@google.com

[karlklose, 2015-07-24 08:27:56]

karlklose@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-07-24 08:27:57]

LGTM.

https://codereview.chromium.org/1256583002/diff/1/tests/language/symbol_confl...
File tests/language/symbol_conflict_test.dart (right):

https://codereview.chromium.org/1256583002/diff/1/tests/language/symbol_confl...
tests/language/symbol_conflict_test.dart:54: if
(!RESERVED_WORDS.contains('$c1$c2')) {
You could actually make a multi-test that also tests that the compiler/analyzer
emits a compile-time error when encountering one of these by adding a counter id
and:
  } else {
    print("  const Symbol('$c1$c2'),  /// ${++id}: compile-time error");
  }

But that would generate to many long tests. Consider adding a
negative/multi-test in addition to this one.

[Paul Berry, 2015-07-24 13:26:25]

https://codereview.chromium.org/1256583002/diff/1/tests/language/symbol_confl...
File tests/language/symbol_conflict_test.dart (right):

https://codereview.chromium.org/1256583002/diff/1/tests/language/symbol_confl...
tests/language/symbol_conflict_test.dart:54: if
(!RESERVED_WORDS.contains('$c1$c2')) {
On 2015/07/24 08:27:57, karlklose wrote:
> You could actually make a multi-test that also tests that the
compiler/analyzer
> emits a compile-time error when encountering one of these by adding a counter
id
> and:
>   } else {
>     print("  const Symbol('$c1$c2'),  /// ${++id}: compile-time error");
>   }
> 
> But that would generate to many long tests. Consider adding a
> negative/multi-test in addition to this one.

Actually there is already a test which verifies that "const Symbol('<keyword>')"
leads to a compile-time error: tests/corelib/symbol_reserved_word_test.dart/10. 
The VM and dart2js currently fail this test due to bugs 11669 and 19972.

I suppose that test really ought to be split up into one multitest case per
keyword (currently there's a single multitest case for all keywords, so if there
were a bug where the implementation allowed some keywords but not others, that
bug wouldn't be caught).  But considering that no one has found bug 11669
important enough to fix in two years (!) I'm having trouble getting excited
about changing anything :)

[Paul Berry, 2015-07-24 13:33:58]

Committed patchset #1 (id:1) manually as
926525dab05cf49dd2935110bffcc3d8026ade3f (presubmit successful).

[floitsch, 2015-07-29 15:22:44]

LGTM.
thanks.