Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1256533002: Revert of Set a new TLS when using CLONE_VM. (Closed)

Created:
5 years, 5 months ago by Alexander Potapenko
Modified:
5 years, 5 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set a new TLS when using CLONE_VM. (patchset #4 id:80001 of https://codereview.chromium.org/1248673004/) Reason for revert: This CL has broken ASan Linux (sandboxed) tests: basically every test from browser_tests, content_browsertests, interactive_ui_tests times out: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/15502 Original issue's description: > Set a new TLS when using CLONE_VM. > > On some libcs, clone writes to the new child's TLS before returning, so > we set a new TLS to avoid corrupting the parent process's TLS. > > On glibc, this caused an assertion failure inside of > pthread_getattr_np(pthread_self(), &attr). > > BUG=512623 > > Committed: https://crrev.com/d2516cf1c3843541c920a476315e2a6f10cb0f92 > Cr-Commit-Position: refs/heads/master@{#340025} TBR=jln@chromium.org,rickyz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512623 Committed: https://crrev.com/eccffe499e5a28eeaa68a135008ddd7a8534bdf7 Cr-Commit-Position: refs/heads/master@{#340069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -46 lines) Patch
M sandbox/linux/services/credentials.cc View 2 chunks +3 lines, -19 lines 0 comments Download
M sandbox/linux/services/credentials_unittest.cc View 2 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
Created Revert of Set a new TLS when using CLONE_VM.
5 years, 5 months ago (2015-07-23 11:01:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256533002/1
5 years, 5 months ago (2015-07-23 11:02:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 11:03:26 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 11:04:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eccffe499e5a28eeaa68a135008ddd7a8534bdf7
Cr-Commit-Position: refs/heads/master@{#340069}

Powered by Google App Engine
This is Rietveld 408576698