Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1256473002:
Re-enable ChannelMojo (Closed)
|
Created:
5 years, 5 months ago by Ken Rockot(use gerrit already) Modified:
5 years, 4 months ago Reviewers:
jam CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable ChannelMojo
I'm pretty sure the previous perf regression was a false
signal. Haven't reproed with other benchmarks and in
retrospect turning ChannelMojo off never fixed the
regression in question anyway.
BUG=500019
Committed: https://crrev.com/ccfe630130d0b4768338a88361c98cc8fc35f758
Cr-Commit-Position: refs/heads/master@{#340975}
Patch Set 1 : #
Messages
Total messages: 21 (11 generated)
rockot@chromium.org changed reviewers: + jam@chromium.org
lgtm
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256473002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256473002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #4 (id:60001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was checked by rockot@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org Link to the patchset: https://codereview.chromium.org/1256473002/#ps80001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256473002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256473002/80001
Message was sent while issue was closed.
Committed patchset #1 (id:80001)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ccfe630130d0b4768338a88361c98cc8fc35f758 Cr-Commit-Position: refs/heads/master@{#340975}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:80001) has been created in https://codereview.chromium.org/1256033004/ by rockot@chromium.org. The reason for reverting is: Maybe breaking layout tests...somehow. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
