Issue 125643002: Convert most of base and net to use base::File

Issue 125643002: Convert most of base and net to use base::File (Closed)

Created:
6 years, 11 months ago by rvargas (doing something else)

Modified:
6 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, gavinp+disk_chromium.org, kalyank, erikwright+watch_chromium.org, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert most of base and net to use base::File BUG=322664 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243852

Patch Set 2 : Use error_details() #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -198 lines)			Patch
M	base/files/scoped_temp_dir_unittest.cc	View	1	2 chunks	+6 lines, -10 lines	0 comments	Download
M	net/android/cert_verify_result_android.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/base/directory_lister_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/disk_cache/flash/storage.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/disk_cache/flash/storage.cc	View		2 chunks	+8 lines, -12 lines	0 comments	Download
M	net/disk_cache/simple/simple_index_file.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/disk_cache/simple/simple_synchronous_entry.h	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	net/disk_cache/simple/simple_synchronous_entry.cc	View	1	33 chunks	+91 lines, -135 lines	2 comments	Download
M	net/disk_cache/simple/simple_util.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/simple/simple_version_upgrade.cc	View	1	3 chunks	+21 lines, -26 lines	0 comments	Download
M	net/url_request/url_request_file_job.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nico

https://codereview.chromium.org/125643002/diff/1/base/files/scoped_temp_dir_unittest.cc File base/files/scoped_temp_dir_unittest.cc (right): https://codereview.chromium.org/125643002/diff/1/base/files/scoped_temp_dir_unittest.cc#newcode104 base/files/scoped_temp_dir_unittest.cc:104: EXPECT_EQ(base::File::FILE_OK, file.error()); Left a comment on https://codereview.chromium.org/93513002/

6 years, 11 months ago (2014-01-08 03:28:55 UTC) #2

Nico

lgtm https://codereview.chromium.org/125643002/diff/220001/net/disk_cache/simple/simple_synchronous_entry.cc File net/disk_cache/simple/simple_synchronous_entry.cc (right): https://codereview.chromium.org/125643002/diff/220001/net/disk_cache/simple/simple_synchronous_entry.cc#newcode612 net/disk_cache/simple/simple_synchronous_entry.cc:612: DVLOG(1) << "EOF record had bad crc."; Is ...

6 years, 11 months ago (2014-01-08 23:40:16 UTC) #4

rvargas (doing something else)

https://codereview.chromium.org/125643002/diff/220001/net/disk_cache/simple/simple_synchronous_entry.cc File net/disk_cache/simple/simple_synchronous_entry.cc (right): https://codereview.chromium.org/125643002/diff/220001/net/disk_cache/simple/simple_synchronous_entry.cc#newcode612 net/disk_cache/simple/simple_synchronous_entry.cc:612: DVLOG(1) << "EOF record had bad crc."; On 2014/01/08 ...

6 years, 11 months ago (2014-01-09 04:11:45 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/125643002/220001

6 years, 11 months ago (2014-01-09 04:13:25 UTC) #6

Message was sent while issue was closed.

Change committed as 243852

Expand Messages | Collapse Messages