Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1256413005: Bugfix: Incorrect type feedback vector structure on recompile. (Closed)

Created:
5 years, 4 months ago by mvstanton
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bugfix: Incorrect type feedback vector structure on recompile. Scoping rules are different on recompile vis-a-vis global loads. BUG=chromium:514526 LOG=y NOTREECHECKS=true Committed: https://crrev.com/d2e815f15be1682bb4b44d6b9f9f4aad47341f10 Cr-Commit-Position: refs/heads/master@{#29896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/scopes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
PTAL, thx!
5 years, 4 months ago (2015-07-28 13:37:18 UTC) #2
Benedikt Meurer
LGTM!
5 years, 4 months ago (2015-07-28 13:38:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256413005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256413005/1
5 years, 4 months ago (2015-07-28 13:39:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 14:02:54 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 14:03:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2e815f15be1682bb4b44d6b9f9f4aad47341f10
Cr-Commit-Position: refs/heads/master@{#29896}

Powered by Google App Engine
This is Rietveld 408576698