Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chromeos/dbus/system_clock_client.cc

Issue 12564007: Hook up system clock update dbus signal to chrome and ash tray ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix MockDBusThreadManagerWithoutGMock compiling issue. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chromeos/dbus/system_clock_client.h ('K') | « chromeos/dbus/system_clock_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/system_clock_client.cc
diff --git a/chromeos/dbus/system_clock_client.cc b/chromeos/dbus/system_clock_client.cc
new file mode 100644
index 0000000000000000000000000000000000000000..aab7173f7889fba3d8a267309331a975437e09c7
--- /dev/null
+++ b/chromeos/dbus/system_clock_client.cc
@@ -0,0 +1,104 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/dbus/system_clock_client.h"
+
+#include "base/bind.h"
+#include "dbus/bus.h"
+#include "dbus/message.h"
+#include "dbus/object_path.h"
+#include "dbus/object_proxy.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
+
+namespace chromeos {
+
+// The SystemClockClient implementation used in production.
+class SystemClockClientImpl : public SystemClockClient {
+ public:
+ explicit SystemClockClientImpl(dbus::Bus* bus)
+ : system_clock_proxy_(NULL),
+ weak_ptr_factory_(this) {
+ system_clock_proxy_ = bus->GetObjectProxy(
+ system_clock::kSystemClockServiceName,
+ dbus::ObjectPath(system_clock::kSystemClockServicePath));
+
+ // Monitor the D-Bus signal for TimeUpdated changes.
+ system_clock_proxy_->ConnectToSignal(
+ system_clock::kSystemClockInterface,
+ system_clock::kSystemClockUpdated,
+ base::Bind(&SystemClockClientImpl::TimeUpdatedReceived,
+ weak_ptr_factory_.GetWeakPtr()),
+ base::Bind(&SystemClockClientImpl::TimeUpdatedConnected,
+ weak_ptr_factory_.GetWeakPtr()));
+ }
+
+ virtual ~SystemClockClientImpl() {
+ }
+
+ // SystemClockClient overrides:
+ virtual void AddObserver(Observer* observer) OVERRIDE {
+ observers_.AddObserver(observer);
+ }
+
+ virtual void RemoveObserver(Observer* observer) OVERRIDE {
+ observers_.RemoveObserver(observer);
+ }
+
+ virtual bool HasObserver(Observer* observer) OVERRIDE {
+ return observers_.HasObserver(observer);
+ }
+
+ private:
+ // Called when a TimeUpdated signal is received.
+ void TimeUpdatedReceived(dbus::Signal* signal) {
+ VLOG(1) << "TimeUpdated signal received: " << signal->ToString();
+ dbus::MessageReader reader(signal);
+ FOR_EACH_OBSERVER(Observer, observers_, SystemClockUpdated());
+ }
+
+ // Called when the TimeUpdated signal is initially connected.
+ void TimeUpdatedConnected(const std::string& interface_name,
+ const std::string& signal_name,
+ bool success) {
+ LOG_IF(WARNING, !success)
stevenjb 2013/03/13 17:34:31 ERROR
jennyz 2013/03/13 19:14:02 Done.
+ << "Failed to connect to TimeUpdated signal.";
stevenjb 2013/03/13 17:34:31 DISALLOW...
jennyz 2013/03/13 19:14:02 which this refers to?
stevenjb 2013/03/13 19:22:39 Nevermind, I missed it below somehow.
+ }
+
+ dbus::ObjectProxy* system_clock_proxy_;
+ ObserverList<Observer> observers_;
+
+ // Note: This should remain the last member so it'll be destroyed and
+ // invalidate its weak pointers before any other members are destroyed.
+ base::WeakPtrFactory<SystemClockClientImpl> weak_ptr_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(SystemClockClientImpl);
+};
+
+// The SystemClockClient implementation used on Linux desktop,
+// which does nothing.
+class SystemClockClientStubImpl : public SystemClockClient {
stevenjb 2013/03/13 17:34:31 public destructor
jennyz 2013/03/13 19:14:02 Done.
+ // SystemClockClient overrides:
+ virtual void AddObserver(Observer* observer) OVERRIDE {}
+ virtual void RemoveObserver(Observer* observer) OVERRIDE {}
+ virtual bool HasObserver(Observer* observer) OVERRIDE { return false; }
stevenjb 2013/03/13 17:34:31 DISALLOW...
jennyz 2013/03/13 19:14:02 Done.
+};
+
+SystemClockClient::SystemClockClient() {
+}
+
+SystemClockClient::~SystemClockClient() {
+}
+
+// static
+SystemClockClient* SystemClockClient::Create(
+ DBusClientImplementationType type,
+ dbus::Bus* bus) {
+ if (type == REAL_DBUS_CLIENT_IMPLEMENTATION) {
+ return new SystemClockClientImpl(bus);
+ }
+ DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
+ return new SystemClockClientStubImpl();
+}
+
+} // namespace chromeos
« chromeos/dbus/system_clock_client.h ('K') | « chromeos/dbus/system_clock_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698