Hook up system clock update dbus signal to chrome and ash tray ui.

chrome/browser/chromeos/system/ash_system_tray_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/system/ash_system_tray_delegate.h"
 
 #include <algorithm>
 
 #include "ash/ash_switches.h"
 #include "ash/shell.h"
@@ skipping 64 matching lines @@
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/upgrade_detector.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/power_manager_client.h"
 #include "chromeos/dbus/session_manager_client.h"
+#include "chromeos/dbus/system_clock_client.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/user_metrics.h"
 #include "device/bluetooth/bluetooth_adapter.h"
 #include "device/bluetooth/bluetooth_adapter_factory.h"
 #include "device/bluetooth/bluetooth_device.h"
 #include "grit/ash_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 95 matching lines @@
                            public PowerManagerClient::Observer,
                            public SessionManagerClient::Observer,
                            public NetworkMenuIcon::Delegate,
                            public NetworkMenu::Delegate,
                            public NetworkLibrary::NetworkManagerObserver,
                            public NetworkLibrary::NetworkObserver,
                            public google_apis::DriveServiceObserver,
                            public content::NotificationObserver,
                            public input_method::InputMethodManager::Observer,
                            public system::TimezoneSettings::Observer,
+                           public chromeos::SystemClockClient::Observer,
                            public device::BluetoothAdapter::Observer,
                            public SystemKeyEventListener::CapsLockObserver,
                            public ash::NetworkTrayDelegate,
                            public policy::CloudPolicyStore::Observer {
  public:
   SystemTrayDelegate()
       : ui_weak_ptr_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(
             new base::WeakPtrFactory<SystemTrayDelegate>(this))),
         network_icon_(ALLOW_THIS_IN_INITIALIZER_LIST(
                       new NetworkMenuIcon(this, NetworkMenuIcon::MENU_MODE))),
@@ skipping 48 matching lines @@
         PowerManagerClient::UPDATE_INITIAL);
     DBusThreadManager::Get()->GetSessionManagerClient()->AddObserver(this);
 
     NetworkLibrary* crosnet = CrosLibrary::Get()->GetNetworkLibrary();
     crosnet->AddNetworkManagerObserver(this);
     OnNetworkManagerChanged(crosnet);
 
     input_method::GetInputMethodManager()->AddObserver(this);
 
     system::TimezoneSettings::GetInstance()->AddObserver(this);
+    DBusThreadManager::Get()->GetSystemClockClient()->AddObserver(this);

[stevenjb, 2013/03/13 17:34:31]

What do you think of making TrayClock a SystemClockClient::Observer instead of
using the delegate? Eventually we want to move TimezoneSettings into
src/chromeos also and remove ClockObserver entirely. This means moving TrayClock
into ash/system/chromeos, which seems fine.

[jennyz, 2013/03/13 19:14:02]

I am not sure if TrayDate is chromeos only, or will it be used on other aura
enabled platform as well? If it is chromeos only, it makes sense to move it to
ash/system/chromeos and have it be chromeos::SystemClockClient::Observer. Can we
defer this task to a separate refactor bug? This is to fix the P1 bug which has
been lingering for a long time and needs to be ported back to R26.

[stevenjb, 2013/03/13 19:22:39]

So, TrayClock is already effectively chromeos specific, since as near as I can
tell system::TimezoneSettings is chromeos-only, as is SystemClockClient. If/when
we want to add one for other platforms we would rename the existing one as
TrayClockChromeos and add TrayClockWindows (or whatever), possibly with a common
TrayClock interface. We still shouldn't be calling into Chrome for OS specific
calls.

That said, if you would rather that be done in a separate pass I am OK with
that, but we are making additional work for ourselves later.

[jennyz, 2013/03/13 20:47:16]

I need to jump to audio work for M27. I filed crbug.com/190299 for the work
item, I will take this work when I got the audio work done. Thanks!

 
     if (SystemKeyEventListener::GetInstance())
       SystemKeyEventListener::GetInstance()->AddCapsLockObserver(this);
 
     network_icon_->SetResourceColorTheme(NetworkMenuIcon::COLOR_LIGHT);
     network_icon_dark_->SetResourceColorTheme(NetworkMenuIcon::COLOR_DARK);
     network_icon_vpn_->SetResourceColorTheme(NetworkMenuIcon::COLOR_DARK);
 
     device::BluetoothAdapterFactory::GetAdapter(
         base::Bind(&SystemTrayDelegate::InitializeOnAdapterReady,
@@ skipping 28 matching lines @@
       policy_manager->core()->store()->AddObserver(this);
     UpdateEnterpriseDomain();
   }
 
   virtual ~SystemTrayDelegate() {
     AudioHandler* audiohandler = AudioHandler::GetInstance();
     if (audiohandler)
       audiohandler->RemoveVolumeObserver(this);
     DBusThreadManager::Get()->GetSessionManagerClient()->RemoveObserver(this);
     DBusThreadManager::Get()->GetPowerManagerClient()->RemoveObserver(this);
+    DBusThreadManager::Get()->GetSystemClockClient()->RemoveObserver(this);
     NetworkLibrary* crosnet = CrosLibrary::Get()->GetNetworkLibrary();
     if (crosnet)
       crosnet->RemoveNetworkManagerObserver(this);
     input_method::GetInputMethodManager()->RemoveObserver(this);
     system::TimezoneSettings::GetInstance()->RemoveObserver(this);
     if (SystemKeyEventListener::GetInstance())
       SystemKeyEventListener::GetInstance()->RemoveCapsLockObserver(this);
     bluetooth_adapter_->RemoveObserver(this);
 
     // Stop observing gdata operations.
@@ skipping 974 matching lines @@
   DriveSystemService* FindDriveSystemService() {
     Profile* profile = ProfileManager::GetDefaultProfile();
     return DriveSystemServiceFactory::FindForProfile(profile);
   }
 
   // Overridden from system::TimezoneSettings::Observer.
   virtual void TimezoneChanged(const icu::TimeZone& timezone) OVERRIDE {
     GetSystemTrayNotifier()->NotifyRefreshClock();
   }
 
+  // Overridden from SystemClockClient::Observer.
+  virtual void SystemClockUpdated() OVERRIDE {
+    GetSystemTrayNotifier()->NotifySystemClockTimeUpdated();
+  }
+
   // Overridden from BluetoothAdapter::Observer.
   virtual void AdapterPresentChanged(device::BluetoothAdapter* adapter,
                                      bool present) OVERRIDE {
     GetSystemTrayNotifier()->NotifyRefreshBluetooth();
   }
 
   virtual void AdapterPoweredChanged(device::BluetoothAdapter* adapter,
                                      bool powered) OVERRIDE {
     GetSystemTrayNotifier()->NotifyRefreshBluetooth();
   }
@@ skipping 144 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(SystemTrayDelegate);
 };
 
 }  // namespace
 
 ash::SystemTrayDelegate* CreateSystemTrayDelegate() {
   return new chromeos::SystemTrayDelegate();
 }
 
 }  // namespace chromeos