Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 12564003: Fix extensions string (Closed)

Created:
7 years, 9 months ago by bsalomon
Modified:
7 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make extension string parsing robust. Committed: https://code.google.com/p/skia/source/detail?r=8040

Patch Set 1 #

Patch Set 2 : Improve comment #

Patch Set 3 : Upload correct patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M src/gpu/gl/GrGLExtensions.cpp View 1 2 1 chunk +10 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
This tries to be more robust and less clever about preallocating the fStrings array.
7 years, 9 months ago (2013-03-08 15:50:30 UTC) #1
robertphillips
lgtm
7 years, 9 months ago (2013-03-08 16:03:43 UTC) #2
bsalomon
Make extension string parsing robust. M src\gpu\gl\GrGLExtensions.cpp
7 years, 9 months ago (2013-03-08 16:05:29 UTC) #3
bsalomon
7 years, 9 months ago (2013-03-08 16:06:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r8040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698