Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2926)

Unified Diff: base/metrics/histogram_unittest.cc

Issue 1256363002: Add support to increase a UMA histogram bucket by an aribitrary integer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/histogram_unittest.cc
diff --git a/base/metrics/histogram_unittest.cc b/base/metrics/histogram_unittest.cc
index f189267f3587affbf6624455ca0a6426cfd21ed5..7296c5ff9c0e1ac6d5ab61ae2ce263d8717aea94 100644
--- a/base/metrics/histogram_unittest.cc
+++ b/base/metrics/histogram_unittest.cc
@@ -231,6 +231,31 @@ TEST_F(HistogramTest, CustomHistogramWithOnly2Buckets) {
EXPECT_EQ(HistogramBase::kSampleType_MAX, ranges->range(2));
}
+// Test the MultiAdd Function
bengr 2015/07/28 17:18:10 Function -> function.
+TEST_F(HistogramTest, MultiAddTest) {
+ const size_t kBucketCount = 50;
+ Histogram* histogram = static_cast<Histogram*>(
+ Histogram::FactoryGet("MultiAddHistogram", 10, 100, kBucketCount,
+ HistogramBase::kNoFlags));
+
+ histogram->MultiAdd(20, 15);
+ histogram->MultiAdd(30, 14);
+
+ scoped_ptr<SampleVector> samples = histogram->SnapshotSampleVector();
+ EXPECT_EQ(29, samples->TotalCount());
+ EXPECT_EQ(15, samples->GetCount(20));
+ EXPECT_EQ(14, samples->GetCount(30));
+
+ histogram->MultiAdd(20, 25);
+ histogram->MultiAdd(30, 24);
+
+ scoped_ptr<SampleVector> samples2 = histogram->SnapshotSampleVector();
+ EXPECT_EQ(78, samples2->TotalCount());
+ EXPECT_EQ(40, samples2->GetCount(20));
+ EXPECT_EQ(38, samples2->GetCount(30));
+
+}
+
// Make sure histogram handles out-of-bounds data gracefully.
TEST_F(HistogramTest, BoundsTest) {
const size_t kBucketCount = 50;

Powered by Google App Engine
This is Rietveld 408576698