Add support to increase a UMA histogram bucket by an aribitrary integer.

base/metrics/histogram.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Histogram is an object that aggregates statistics, and can summarize them in
 // various forms, including ASCII graphical, HTML, and numerically (as a
 // vector of numbers corresponding to each of the aggregating buckets).
 // See header file for details and examples.
 
 #include "base/metrics/histogram.h"
@@ skipping 253 matching lines @@
 }
 
 bool Histogram::HasConstructionArguments(Sample expected_minimum,
                                          Sample expected_maximum,
                                          size_t expected_bucket_count) const {
   return ((expected_minimum == declared_min_) &&
           (expected_maximum == declared_max_) &&
           (expected_bucket_count == bucket_count()));
 }
 
+int ClampValue(int value) {

[Alexei Svitkine (slow), 2015/08/03 18:15:42]

Put this in the anon namespace at the top of the file. Add a comment.

Alternatively, since you're making Add() call AddCount() now, maybe just keep
this inside the method like before instead of a separate helper.

[amohammadkhan, 2015/08/04 18:22:51]

Done.

+  if (value > Histogram::kSampleType_MAX - 1)
+    return Histogram::kSampleType_MAX - 1;
+  if (value < 0)
+    return 0;
+  return value;
+}
+
 void Histogram::Add(int value) {
+  AddCount(value, 1);
+}
+
+void Histogram::AddCount(int value, int count) {
   DCHECK_EQ(0, ranges(0));
   DCHECK_EQ(kSampleType_MAX, ranges(bucket_count()));
+  if (count < 0) {

[Alexei Svitkine (slow), 2015/08/03 18:15:42]

If the body is a single line, no need for {}'s.

[amohammadkhan, 2015/08/04 18:22:51]

Done.

+    count = 0;

[Alexei Svitkine (slow), 2015/08/03 18:15:42]

Seems like a count of 0 would actually not change anything. Suggesting change if
to be <= 0 and then doing a return with a NOTREACHED() inside it.

[amohammadkhan, 2015/08/04 18:22:51]

Done.

+  }
+  int clamped_value = ClampValue(value);
+  samples_->Accumulate(clamped_value, count);
 
-  if (value > kSampleType_MAX - 1)
-    value = kSampleType_MAX - 1;
-  if (value < 0)
-    value = 0;
-  samples_->Accumulate(value, 1);
-
-  FindAndRunCallback(value);
+  FindAndRunCallback(clamped_value);
 }
 
 scoped_ptr<HistogramSamples> Histogram::SnapshotSamples() const {
   return SnapshotSampleVector().Pass();
 }
 
 void Histogram::AddSamples(const HistogramSamples& samples) {
   samples_->Add(samples);
 }
 
@@ skipping 589 matching lines @@
 
   BucketRanges* bucket_ranges = new BucketRanges(ranges.size());
   for (size_t i = 0; i < ranges.size(); i++) {
     bucket_ranges->set_range(i, ranges[i]);
   }
   bucket_ranges->ResetChecksum();
   return bucket_ranges;
 }
 
 }  // namespace base