Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: chrome/browser/about_flags.cc

Issue 1256343004: [Android] Add phone progress bar animation behind a flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: telemetry_perf_unittest fix attempt #1 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index ffd88227a02e3cd8a90720612e86c8acd2146d5a..c1f1e924eb8b187b88cde8e9005a8ffa4e49b042 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -546,6 +546,18 @@ const Experiment::Choice kV8CacheOptionsChoices[] = {
{ IDS_FLAGS_V8_CACHE_OPTIONS_CODE, switches::kV8CacheOptions, "code" },
};
+#if defined(OS_ANDROID)
+const Experiment::Choice kProgressBarAnimationChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
+ switches::kProgressBarAnimation, "disabled" },
+ { IDS_FLAGS_PROGRESS_BAR_ANIMATION_SMOOTH,
+ switches::kProgressBarAnimation, "smooth" },
+ { IDS_FLAGS_PROGRESS_BAR_ANIMATION_FAST_START,
+ switches::kProgressBarAnimation, "fast-start" },
+};
+#endif // defined(OS_ANDROID)
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -2079,6 +2091,14 @@ const Experiment kExperiments[] = {
ENABLE_DISABLE_VALUE_TYPE(switches::kEnableSimplifiedFullscreenUI,
switches::kDisableSimplifiedFullscreenUI)
},
+#if defined(OS_ANDROID)
+ {"progress-bar-animation",
+ IDS_FLAGS_PROGRESS_BAR_ANIMATION_NAME,
+ IDS_FLAGS_PROGRESS_BAR_ANIMATION_DESCRIPTION,
+ kOsAndroid,
+ MULTI_VALUE_TYPE(kProgressBarAnimationChoices)},
+#endif // defined(OS_ANDROID)
+
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

Powered by Google App Engine
This is Rietveld 408576698