Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2365)

Issue 125633003: [rAc - libaddressinput] slay another helper class (Closed)

Created:
6 years, 11 months ago by Evan Stade
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[rAc - libaddressinput] slay another helper class remove AddressValidator; the functionality will be added to AddressValidator BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -258 lines) Patch
M third_party/libaddressinput/chromium/cpp/libaddressinput.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/address_validator.cc View 2 chunks +1 line, -2 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/validating_storage.h View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/validating_storage.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/validating_storage_test.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
as discussed before the break.
6 years, 11 months ago (2014-01-07 01:49:33 UTC) #1
please use gerrit instead
lgtm
6 years, 11 months ago (2014-01-07 01:55:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/125633003/1
6 years, 11 months ago (2014-01-07 10:00:10 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242327
6 years, 11 months ago (2014-01-07 12:14:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/125633003/1
6 years, 11 months ago (2014-01-07 20:15:17 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 23:28:40 UTC) #6
Message was sent while issue was closed.
Change committed as 243430

Powered by Google App Engine
This is Rietveld 408576698