Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1256323011: Devtools: refactor shell configuration logic. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Devtools: refactor shell configuration logic. This patch splits the shell configuration logic into part that computes the final list of options (shell_config) and the part that configures the shell abstraction accordingly. This becomes needed as information that affects a shell run (script command-line arguments and inferred checkout paths), and we would like to have another (configuration file). This patch also includesthe logic that infers default paths in Chromium-like checkouts in the common configuration logic, so that it now applies to `mojo_test` as well as to `mojo_run`. R=qsr@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/035f2cc50b8e2aacb3b3a7a8dc504bedfb46bb90

Patch Set 1 : #

Patch Set 2 : Address Ben's offline comments. #

Patch Set 3 : Fix a typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -124 lines) Patch
M mojo/devtools/common/devtoolslib/paths.py View 3 chunks +13 lines, -13 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments.py View 1 2 3 chunks +32 lines, -66 lines 0 comments Download
A mojo/devtools/common/devtoolslib/shell_config.py View 1 1 chunk +121 lines, -0 lines 0 comments Download
M mojo/devtools/common/mojo_run View 1 3 chunks +4 lines, -40 lines 0 comments Download
M mojo/devtools/common/mojo_test View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-07-31 16:59:30 UTC) #3
ppi
Hi Ben, addressed your offline comments, ptal.
5 years, 4 months ago (2015-08-03 11:20:11 UTC) #4
qsr
lgtm
5 years, 4 months ago (2015-08-03 11:24:55 UTC) #5
ppi
5 years, 4 months ago (2015-08-03 11:32:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:80001) manually as
035f2cc50b8e2aacb3b3a7a8dc504bedfb46bb90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698