chrome/renderer/chrome_content_renderer_client.cc - Issue 1256323008: [Extension ServiceWorkers] Chrome: Passing v8::context to extensions dispatcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 1256323008: [Extension ServiceWorkers] Chrome: Passing v8::context to extensions dispatcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | chrome/test/data/extensions/api_test/service_worker/bindings/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index 481b439e666696669ca478967ff2dfcf75f96dff..91333c53cd4468672979f35842ca434dd9a546f5 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -1630,3 +1630,13 @@ void ChromeContentRendererClient::AddImageContextMenuProperties(

data_reduction_proxy::chrome_proxy_lo_fi_directive();

}

+void ChromeContentRendererClient::

Lei Zhang 2015/07/31 21:52:28 nit: I'd rather break the line after void, like on

annekao 2015/08/04 17:02:08 Done.

+ DidInitializeServiceWorkerContextOnWorkerThread(

+ v8::Local<v8::Context> context,

Lei Zhang 2015/07/31 21:52:28 And then 4 space indent this.

annekao 2015/08/04 17:02:08 Done.

+ const GURL& url) {

+#if defined(ENABLE_EXTENSIONS)

+ extensions::Dispatcher::DidInitializeServiceWorkerContextOnWorkerThread(

+ context, url);

+#endif