chrome/test/data/extensions/api_test/service_worker/bindings/sw.js - Issue 1256323008: [Extension ServiceWorkers] Chrome: Passing v8::context to extensions dispatcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/service_worker/bindings/sw.js

Issue 1256323008: [Extension ServiceWorkers] Chrome: Passing v8::context to extensions dispatcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/test/data/extensions/api_test/service_worker/bindings/page.js ('k') | chrome/test/data/extensions/api_test/service_worker/bindings/test.js » ('j') | content/public/renderer/content_renderer_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/service_worker/bindings/sw.js

diff --git a/chrome/test/data/extensions/api_test/service_worker/fetch/sw.js b/chrome/test/data/extensions/api_test/service_worker/bindings/sw.js

similarity index 74%

copy from chrome/test/data/extensions/api_test/service_worker/fetch/sw.js

copy to chrome/test/data/extensions/api_test/service_worker/bindings/sw.js

index d2c5fbdcade4ce5b268c34375dac1c026942c5ba..dd6714abc0bd1ddf6d3824c905515b918d2f6aad 100644

--- a/chrome/test/data/extensions/api_test/service_worker/fetch/sw.js

+++ b/chrome/test/data/extensions/api_test/service_worker/bindings/sw.js

@@ -3,5 +3,6 @@

// found in the LICENSE file.

self.addEventListener('fetch', function(event) {

- event.respondWith(new Response('Caught a fetch!'));

+ var type = typeof chrome;

+ event.respondWith(new Response(type));

Devlin 2015/07/31 16:24:32 you can still inline type. ;) event.RespondWith(n

annekao 2015/07/31 17:13:33 I could've sworn this didn't work yesterday. It w

});