Optimize ToString and NonStringToString.

Optimize ToString and NonStringToString.

Moves some uncommon type checking from ToString and
NonStringToString into DefaultString. This should
speed up string operations.

LOG=N
BUG=none

Committed: https://crrev.com/bfde458271f6500e1b78ee0582646b9fcbefba54
Cr-Commit-Position: refs/heads/master@{#29913}

[bbudge, 2015-07-28 19:07:29]

bbudge@chromium.org changed reviewers:
+ rossberg@chromium.org

[bbudge, 2015-07-28 19:07:30]

In the spirit of the change I made to ToNumber.

This changes the message for the TypeError when converting a Symbol wrapper to a
primitive. I'm not sure if that matters.

This isn't needed for SIMD.

https://codereview.chromium.org/1256323004/diff/20001/src/runtime.js
File src/runtime.js (left):

https://codereview.chromium.org/1256323004/diff/20001/src/runtime.js#oldcode769
src/runtime.js:769: if (IS_SYMBOL_WRAPPER(x)) throw
MakeTypeError(kSymbolToPrimitive);
Is this error part of the Spec? If so, we have to keep this line.

[bbudge, 2015-07-29 00:20:00]

On 2015/07/28 19:07:30, bbudge wrote:
> In the spirit of the change I made to ToNumber.
> 
> This changes the message for the TypeError when converting a Symbol wrapper to
a
> primitive. I'm not sure if that matters.
> 
> This isn't needed for SIMD.
> 
> https://codereview.chromium.org/1256323004/diff/20001/src/runtime.js
> File src/runtime.js (left):
> 
>
https://codereview.chromium.org/1256323004/diff/20001/src/runtime.js#oldcode769
> src/runtime.js:769: if (IS_SYMBOL_WRAPPER(x)) throw
> MakeTypeError(kSymbolToPrimitive);
> Is this error part of the Spec? If so, we have to keep this line.

I mean the specific text description that says this is a Symbol wrapper object.

[rossberg, 2015-07-29 11:49:12]

lgtm

https://codereview.chromium.org/1256323004/diff/20001/src/runtime.js
File src/runtime.js (left):

https://codereview.chromium.org/1256323004/diff/20001/src/runtime.js#oldcode769
src/runtime.js:769: if (IS_SYMBOL_WRAPPER(x)) throw
MakeTypeError(kSymbolToPrimitive);
On 2015/07/28 19:07:30, bbudge wrote:
> Is this error part of the Spec? If so, we have to keep this line.

No, the spec doesn't even recognise the existence of error messages.

[bbudge, 2015-07-29 13:56:45]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2015-07-29 13:57:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1256323004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1256323004/20001

[commit-bot: I haz the power, 2015-07-30 08:21:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-30 08:22:06]

Patchset 2 (id:??) landed as
https://crrev.com/bfde458271f6500e1b78ee0582646b9fcbefba54
Cr-Commit-Position: refs/heads/master@{#29913}