device/bluetooth/bluetooth_device.cc - Issue 1256313002: bluetooth: android: Implement & test CreateGattConnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_device.cc

Issue 1256313002: bluetooth: android: Implement & test CreateGattConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added 2 more connect/disconnect test blocks Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/bluetooth/bluetooth_device.cc

diff --git a/device/bluetooth/bluetooth_device.cc b/device/bluetooth/bluetooth_device.cc

index 34b2260059f1895a515b2dc7d127d89b7f5f1a48..3516da0a058304946173c30a0659767c2ca3b66e 100644

--- a/device/bluetooth/bluetooth_device.cc

+++ b/device/bluetooth/bluetooth_device.cc

@@ -210,7 +210,7 @@ void BluetoothDevice::CreateGattConnection(

create_gatt_connection_error_callbacks_.push_back(error_callback);

if (IsGattConnected())

- DidConnectGatt();

+ return DidConnectGatt();

CreateGattConnectionImpl();

}

« no previous file with comments | « device/bluetooth/bluetooth_device.h ('k') | device/bluetooth/bluetooth_device_android.h » ('j') | device/bluetooth/bluetooth_device_unittest.cc » ('J')