bluetooth: android: Implement & test CreateGattConnection.

device/bluetooth/bluetooth_device_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_device.h"
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "device/bluetooth/test/test_bluetooth_adapter_observer.h"
@@ skipping 107 matching lines @@
 }
 #endif  // defined(OS_ANDROID) || defined(OS_MACOSX)
 
 // TODO(scheib): Test with a device with no name. http://crbug.com/506415
 // BluetoothDevice::GetAddressWithLocalizedDeviceTypeName() will run, which
 // requires string resources to be loaded. For that, something like
 // InitSharedInstance must be run. See unittest files that call that. It will
 // also require build configuration to generate string resources into a .pak
 // file.
 
+#if defined(OS_ANDROID)
+// Basic CreateGattConnection test.
+TEST_F(BluetoothTest, CreateGattConnection) {
+  InitWithFakeAdapter();
+  TestBluetoothAdapterObserver observer(adapter_);
+
+  // Get a device.
+  adapter_->StartDiscoverySession(GetDiscoverySessionCallback(),
+                                  GetErrorCallback());
+  base::RunLoop().RunUntilIdle();
+  DiscoverLowEnergyDevice(3);
+  base::RunLoop().RunUntilIdle();
+  BluetoothDevice* device = observer.last_device();
+
+  callback_count_ = error_callback_count_ = 0;
+  device->CreateGattConnection(GetGattConnectionCallback(),

[Jeffrey Yasskin, 2015/08/20 21:35:14]

Can we also see some more complex interleavings of CreateGattConnection and
Disconnect calls, to see how the callbacks get fired?

[scheib, 2015/09/13 02:41:01]

Done.

+                               GetConnectErrorCallback());
+  CompleteGattConnection(device);
+  EXPECT_EQ(1, callback_count_--);

[Jeffrey Yasskin, 2015/08/20 21:35:14]

I'd rather assign callback_count_ on a separate line here too.

[scheib, 2015/09/13 02:41:01]

I think this makes the test harder to read, but OK.

+  EXPECT_EQ(0, error_callback_count_);
+  ASSERT_EQ(1u, gatt_connections_.size());
+  EXPECT_TRUE(device->IsGattConnected());
+
+  // Connect again once already connected.
+  device->CreateGattConnection(GetGattConnectionCallback(),
+                               GetConnectErrorCallback());
+  EXPECT_EQ(1, callback_count_--);
+  EXPECT_EQ(0, error_callback_count_);
+  ASSERT_EQ(2u, gatt_connections_.size());
+}
+#endif  // defined(OS_ANDROID)
+
 }  // namespace device