Creating Ui for Battery State Option in Chrome Os Emulator

chrome/browser/resources/chromeos/emulator/battery_settings.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var BatterySettings = Polymer({
   is: 'battery-settings',
 
   properties: {
     /**
      * The system's battery percentage.
      */
     batteryPercent: {
       type: Number,
     },
 
     /**
      * A string representing the value of an

[michaelpg, 2015/07/27 20:46:22]

nit: "of a"

[mozartalouis, 2015/07/27 23:58:41]

Done.

+     * PowerSupplyProperties_BatteryState enumeration.
+     */
+    batteryState: {
+      type: String,
+    },
+
+    /**
+      * An array representing the battery state options.

[michaelpg, 2015/07/27 20:46:22]

fix indent (-1)

[mozartalouis, 2015/07/27 23:58:41]

Done.

+      * The names are ordered based on the
+      * PowerSupplyProperties_BatteryState enumeration. These values must be
+      * in sync.
+      */
+    batteryStateOptions: {
+      type: Array,
+      value: function() { return ['Full', 'Charging', 'Disharging',
+      'Not Present']; }
+    },
+
+    /**
+     * A string representing the value of an

[michaelpg, 2015/07/27 20:46:22]

nit: "of a"

[mozartalouis, 2015/07/27 23:58:41]

Done.

      * PowerSupplyProperties_ExternalPower enumeration.
      */
     externalPower: {
       type: String,
     },
 
     /**
       * An array representing the external power options.
       * The names are ordered based on the
       * PowerSupplyProperties_ExternalPower enumeration. These values must be
@@ skipping 25 matching lines @@
       type: String,
     },
   },
 
   ready: function() {
     this.title = 'Power Settings';
   },
 
   observers: [
     'batteryPercentChanged(batteryPercent)',
+    'batteryStateChanged(batteryState)',
     'externalPowerChanged(externalPower)',
     'timeUntilEmptyChanged(timeUntilEmpty)',
     'timeUntilFullChanged(timeUntilFull)',
   ],
 
   batteryPercentChanged: function(percent) {
     chrome.send('updateBatteryPercent', [parseInt(percent)]);
   },
 
+  batteryStateChanged: function(state) {
+    var index = -1;
+
+    // Find the index of the selected battery state.
+    for (var i = 0; i < this.batteryStateOptions.length; i++) {

[michaelpg, 2015/07/27 20:46:22]

var index = this.batteryStateOptions.indexOf(state);

[mozartalouis, 2015/07/27 23:58:41]

Done.

[michaelpg, 2015/07/28 00:05:39]

Take another look at how indexOf works -- you don't need the loop.

+      if (this.batteryStateOptions[i] == state) {
+        index = i;
+        break;
+      }
+    }
+
+    if (index >= 0)
+    chrome.send('updateBatteryState', [index]);

[michaelpg, 2015/07/27 20:46:22]

indent

[mozartalouis, 2015/07/27 23:58:41]

Done.

+  },
+
   externalPowerChanged: function(source) {
     var index = -1;
 
     // Find the index of the selected power source.
     for (var i = 0; i < this.externalPowerOptions.length; i++) {
       if (this.externalPowerOptions[i] == source) {
         index = i;
         break;
       }
     }
 
     if (index >= 0)
       chrome.send('updateExternalPower', [index]);
   },
 
   timeUntilEmptyChanged: function(time) {
     chrome.send('updateTimeToEmpty', [parseInt(time)]);
   },
 
   timeUntilFullChanged: function(time) {
     chrome.send('updateTimeToFull', [parseInt(time)]);
   },
 
-  updatePowerProperties: function(percent, external_power, empty, full) {
+  updatePowerProperties: function(percent, state, source, empty, full) {
     this.batteryPercent = percent;
-    this.externalPower = this.externalPowerOptions[external_power];
+    this.batteryState = this.batteryStateOptions[state];
+    this.externalPower = this.externalPowerOptions[source];
     this.timeUntilEmpty = empty;
     this.timeUntilFull = full;
   }
 });