x11: Include X11 dependencies only when building with X11.

x11: Include X11 dependencies only when building with X11.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186816

[sadrul, 2013-03-07 01:42:00]

More changes to build/link without X11 et al

[Sergey Ulanov, 2013-03-07 02:01:35]

remoting/ - LGTM

[Wez, 2013-03-07 07:39:23]

On 2013/03/07 02:01:35, sergeyu wrote:
> remoting/ - LGTM

remoting/ - !LGTM

The remoting_host target requires X11 when built for Linux, so if there's no X11
then the whole thing needs disabling.

[sadrul, 2013-03-07 07:58:21]

On 2013/03/07 07:39:23, Wez wrote:
> On 2013/03/07 02:01:35, sergeyu wrote:
> > remoting/ - LGTM
> 
> remoting/ - !LGTM
> 
> The remoting_host target requires X11 when built for Linux, so if there's no
X11
> then the whole thing needs disabling.

Ah, I see what you mean. I have made a change to set enable_remoting_host to 1
only when using X11 on linux. Does this look reasonable?

[sadrul, 2013-03-07 07:58:21]

On 2013/03/07 07:39:23, Wez wrote:
> On 2013/03/07 02:01:35, sergeyu wrote:
> > remoting/ - LGTM
> 
> remoting/ - !LGTM
> 
> The remoting_host target requires X11 when built for Linux, so if there's no
X11
> then the whole thing needs disabling.

Ah, I see what you mean. I have made a change to set enable_remoting_host to 1
only when using X11 on linux. Does this look reasonable?

[rjkroege, 2013-03-07 15:54:45]

lgtm

[Wez, 2013-03-07 18:33:01]

lgtm

https://codereview.chromium.org/12563002/diff/17001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/12563002/diff/17001/remoting/remoting.gyp#new...
remoting/remoting.gyp:59: ['OS=="win" or OS=="mac" or (OS=="linux" and
chromeos==0 and use_x11==1)', {
nit: Wrap the open brace to the next line.

[sadrul, 2013-03-07 18:54:12]

+brettw@ for base/ and content/ changes

+scherkus@ for media/ changes

+ben for ui/ changes

[scherkus (not reviewing), 2013-03-07 19:00:18]

media/ lgtm

[Wez, 2013-03-07 19:09:23]

https://codereview.chromium.org/12563002/diff/17001/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/12563002/diff/17001/media/media.gyp#newcode23
media/media.gyp:23: ['OS=="win" or OS=="mac" or OS=="linux"', {
This will need an X11 check as well, since screen capture requires X11 on Linux.

[Sergey Ulanov, 2013-03-07 19:39:09]

https://codereview.chromium.org/12563002/diff/17001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/12563002/diff/17001/remoting/remoting.gyp#new...
remoting/remoting.gyp:59: ['OS=="win" or OS=="mac" or (OS=="linux" and
chromeos==0 and use_x11==1)', {
On 2013/03/07 18:33:01, Wez wrote:
> nit: Wrap the open brace to the next line.

condition wrapping is not a supported feature in gyp, see:
https://codereview.chromium.org/11946026/diff/1/third_party/libjingle/libjing...

[sadrul, 2013-03-07 21:09:56]

https://codereview.chromium.org/12563002/diff/17001/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/12563002/diff/17001/media/media.gyp#newcode23
media/media.gyp:23: ['OS=="win" or OS=="mac" or OS=="linux"', {
On 2013/03/07 19:09:24, Wez wrote:
> This will need an X11 check as well, since screen capture requires X11 on
Linux.

Done.

[Ben Goodger (Google), 2013-03-07 21:34:48]

lgtm

[brettw, 2013-03-07 22:59:55]

lgtm

[sadrul, 2013-03-07 23:23:25]

Committed patchset #4 manually as r186816 (presubmit successful).