Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1256283003: Fully deprecate FixedArray::CopySize method. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_issue-cr-513507
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fully deprecate FixedArray::CopySize method. R=hpayer@chromium.org Committed: https://crrev.com/b04171ad02bd794e406c28e98de49df32ded0ee8 Cr-Commit-Position: refs/heads/master@{#30020}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -55 lines) Patch
M src/api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/contexts.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M src/factory.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/heap/heap.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects.cc View 6 chunks +15 lines, -29 lines 0 comments Download
M src/transitions.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-04 14:22:57 UTC) #1
Hannes Payer (out of office)
nice! lgtm
5 years, 4 months ago (2015-08-04 15:24:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256283003/20001
5 years, 4 months ago (2015-08-05 08:33:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-05 08:54:18 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 08:55:37 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b04171ad02bd794e406c28e98de49df32ded0ee8
Cr-Commit-Position: refs/heads/master@{#30020}

Powered by Google App Engine
This is Rietveld 408576698